Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status / Monitoring - Last Sample Zero #139

Closed
wants to merge 2 commits into from
Closed

Status / Monitoring - Last Sample Zero #139

wants to merge 2 commits into from

Conversation

NOYB
Copy link
Contributor

@NOYB NOYB commented May 31, 2016

Monitoring graphs last sample being zero

If there is no RRD data sample for the current minute then the graph and last and minimum data value will be zero in certain circumstances. Such as resolution 1 minute and graph loaded prior to the current minute RRD sample being made. Similar for the first minute of other resolutions.

This PR corrects this situation by never requesting RRD data for the uncompleted current minute to ensure that there is a data point for the last/end time.

@NOYB
Status / Monitoring - Last Sample Zero
3df032c 
Monitoring graphs last sample being zero

If there is no RRD data sample for the current minute then the graph and last and minimum data value will be zero in certain circumstances.  Such as resolution 1 minute and graph loaded prior to the current minute RRD sample being made.  Similar for the first minute of other resolutions.

This commit corrects this situation by never requesting RRD data for the uncompleted current minute to ensure that there is a data point for the last/end time.
@jdillard jdillard self-assigned this Jun 2, 2016
@jdillard
Copy link
Contributor

jdillard commented Jun 2, 2016

According to this page: http://linux.die.net/man/1/rrdfetch

You can do something like:

end-3weeks or e-3w -- 3 weeks before end time (may be used as start time specification).

which seems cleaner to me.

@NOYB
Implement Jared Dillard suggestion to use the 'end' time reference ke…
d6d2e1e 
…yword for maintaining the time period duration.
netgate-git-updates pushed a commit that referenced this pull request Jun 7, 2016
@jdillard
(status > monitoring) fix resolution interval - adapted from NOYB in #…
a93f57d 
…139
@jdillard
Copy link
Contributor

jdillard commented Jun 7, 2016

I ended up doing it a little different in a93f57d. Notice how there was still a hack in place to remove the last value, which is no longer needed.

I just noticed #145, I'll take a look at that too.

@jdillard jdillard closed this Jun 7, 2016
netgate-git-updates pushed a commit that referenced this pull request Jun 7, 2016
@jdillard
(status > monitoring) fix resolution interval - adapted from NOYB in #…
3234d99 
…139
netgate-git-updates pushed a commit that referenced this pull request Jun 7, 2016
@jdillard
(status > monitoring) fix resolution interval - adapted from NOYB in #…
0ff2dfc 
…139
@NOYB NOYB deleted the Status_/_Monitoring_-_Last_Sample_Zero branch June 7, 2016 02:10
netgate-git-updates pushed a commit that referenced this pull request Aug 26, 2016
Update devel/kyua to 0.13 from 0.11:
80e170b 
**Released on August 26th, 2016.**

* Fixed execution of test cases as an unprivileged user, at least under
  NetBSD 7.0.  Kyua-level failures were probably a regression introduced
  in Kyua 0.12, but the underlying may have existed for much longer:
  test cases might have previously failed for mysterious reasons when
  running under an unprivileged user.

* Issue #134: Fixed metadata test broken on 32-bit platforms.

* Issue #139: Added per-test case start/end timestamps to all reports.

* Issue #156: Fixed crashes due to the invalid handling of cleanup
  routine data and triggered by the reuse of PIDs in long-running Kyua
  instances.

* Issue #159: Fixed TAP parser to ignore case while matching `TODO` and
  `SKIP` directives, and to also recognize `Skipped`.

* Fixed potential crash due to a race condition in the unprogramming of
  timers to control test deadlines.

The above are the major changes in 0.13.  Note that, however, this commit
upgrades devel/kyua from 0.11 because 0.12 was rolled back.  For details
on the changes that went into 0.12, see the log for r402256.

Reviewed by:	ngie
Approved by:	bapt (mentor)
Differential Revision:	https://reviews.freebsd.org/D7642
netgate-git-updates pushed a commit that referenced this pull request Mar 30, 2017
@gahr
irc/bitlbee-facebook: update to 1.1.0 + patch for issue #139
b90161a 
Release notes: https://github.com/bitlbee/bitlbee-facebook/releases/tag/v1.1.0
Issue #139: bitlbee/bitlbee-facebook#139
netgate-git-updates pushed a commit that referenced this pull request Sep 13, 2017
@opsec
mail/opendmarc: update 1.3.1 -> 1.3.2
103bcb6 
Feature request #86: Change meaning of "RequiredHeaders" such that
	header validity is always checked, but messages are only
	rejected on that basis when the flag is set.  Based
	on a patch from Andreas Schulze.
Feature request #127: Log SPF results when rejecting.  Requested
	by Patrick Wagner; patch from Andreas Schulze, follow-up
	patch from Juri Haberland.
Feature request #138: Inculde policy and disposition information
	in an Authentication-Results comment.  Based on a patch
	from Juri Haberland.
Feature request #139: Include the client host name if known
	in failure reports.  Suggested by Roland Turner;
	patch by Andreas Schulze.
Fix bug #95: Assume IPv6 for SPF operations.  Patch from Juri Haberland.
Fix bug #120: Fix control logic around the SPF result.
	Reported by Christophe Wolfhugel; patch from Andreas Schulze.
Fix bug #122: Don't skip the HELO milter phase when SPF is enabled.
	Reported by Christophe Wolfhugel.
Fix bug #157: Fix logging of implicit authserv-ids.  Reported
	by Andreas Schulze; patch from Juri Haberland.
Fix bug #158: Log ignored connections.  Patch from Andreas Schulze.
Fix bug #160: Fix "SyslogFacility" handling.  Patch from
	Juri Haberland.
Fix bug #163: Use a larger buffer for the raw MAIL FROM value.
	Based on a patch from Andreas Schulze.
Fix bug #174: Trim "!" suffixes from reporting addresses.  Problem
	noted by Juri Haberland.
Fix bug #186: When reloading the configuration file, the public
	suffix list was read in with the wrong comment indicator.
	Patch from Federico Omoto.
LIBOPENDMARC: Fix bug #115: Fix type mismatch.  Patch from
	Sebastian A. Siewior via Scott Kitterman.
LIBOPENDMARC: Fix bug #121: Fix IPv6 CIDR matching in SPF code.
	Patch from Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #125: Compile time IPv6 fix.  Reported by
	Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #131: Fix alignment bug.  Patch from
	Andreas Schulze.
LIBOPENDMARC: Fix bug #147: Fix stripping of whitespace from
	DMARC DNS records.  Based on a patch from Job Noorman.
LIBOPENDMARC: Fix bug #149: Apply "sp" setting, if present and
	applicable.  Patch from Petr Novak.
LIBOPENDMARC: Fix bug #154: Fix "rf" and "fo" processing logic.
LIBOPENDMARC: Fix bug #156: Fix variable name.  Patch by
	Andreas Schulze.
LIBOPENDMARC: Fix bug #165: Fix logic in checking which SPF
	identifier was used.  Patches from Marco Favero and
	Juri Haberland.
LIBOPENDMARC: Fix bug #167: Don't return "fail" when we should
	return "none".  Patch from Marco Favero.
REPORTS: Fix bug #134: Handle SMTP errors correctly.  Patch from
	Andreas Schulze.
REPORTS: Fix bug #141: Set the HELO parameter correctly.
	Reported by Alan Smith; patch from Andreas Schulze.
REPORTS: Fix bug #143: Fix logic in table truncation.
	Reported by Wayne Andersen; patch from Juri Haberland.
REPORTS: Fix bug #162: Always report "sp" in aggregate reports.
	Patch from Juri Haberland.
REPORTS: Fix bug #166: Fix report start/end time logic.
	Patch from Juri Haberland.
REPORTS: Fix bug #188: Don't delete inputs too early in
	opendmarc-reports.  Patch from Juri Haberland.
TOOLS: Fix bug #161: "Forensic" reports were renamed "Failure"
	reports.  Patch from Andreas Schulze.
TOOLS: Fix bug #164: Handle IPv6 test addresses.  Reported by
	Andreas Schulze; patch from Juri Haberland.
DOCS: Patch #189: Replace the DMARC RFC with an HTML page
	referencing the relevant specs, since Debian doesn't
	consider RFCs to be "free".  Patch from Scott Kitterman
	via Juri Haberland.

PR:		220902
Submitted by:	Dan Mahoney <[email protected]> (maintainer), Lukasz Wasikowski <[email protected]>
netgate-git-updates pushed a commit that referenced this pull request Mar 3, 2020
@fernape
sysutils/yadm: update to 2.4.0
c204cea 
From ChangeLog: https://github.com/TheLocehiliosan/yadm/releases/tag/2.4.0

Update version number and update documentation

 * Support multiple keys in `yadm.gpg-recipient` (#139)
 * Ensure all templates are written atomically (#142)
 * Add encrypt_with_checksums to the hooks collection (#188)
 * Escape white space in YADM_HOOK_FULL_COMMAND (#187)
 * Improve parsing of os-release (#194)
 * Improve identification of WSL (#196)
 * Fix troff warnings emitted by man page (#195)
 * Write encrypt-based exclusions during decrypt

PR:	244509
Submitted by:	[email protected] (maintainer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdillard jdillard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NOYB @jdillard @netgate-git-updates