-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apcupsd - add package to 2.3 #128
Conversation
Would be wonderful to have apcupsd once more available in 2.3! |
Any issues with bringing this in? I need to slave off another host running apcupsd and NUT does not support that (well, the pfsense pkg does not). There's a redmine ticket here: https://redmine.pfsense.org/issues/6141 |
2.3.2 is out and still no apcupsd :-( |
LICENSE= ESF | ||
|
||
RUN_DEPENDS= ${LOCALBASE}/sbin/apcupsd:sysutils/apcupsd \ | ||
/etc/inc/phpmailer/PHPMailerAutoload.php:mail/pfSense-pkg-mailreport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is mailreport mandatory? I don't like too much the idea of adding dependencies between additional packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's not. It will send just text.
I could change it to send_smtp_message()
https://github.com/pfsense/pfsense/blob/master/src/etc/inc/notices.inc#L309
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good plan. When you do it please remove the message I'll note below
<![CDATA[ | ||
Choose how APCUpsd will send email notifications.<br /><br /> | ||
<strong>phpMailer</strong> - In order to receive e-mail notifications through phpMailer, you need to configure SMTP Email Notifications on Advanced/Notifications section, | ||
and also install mailreport package.<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove reference to mailreport
Hi @rbgarga! |
@dbaio, I've merged it only for 2.3.3-snapshots for now, after receive more positive feedbacks it can go to 2.3.2 repo. Thanks! |
Any chance this will come to the 2.3.2 repo soon? Would be nice to have it. |
@kathode done |
- Updates and documents a patch. Changes since 2.1.1: Library: * A library view showing recent books and reading progress (#119) * Search books by metadata * E-book discovery with OPDS (#6, #253) New supported formats: * FictionBook (.fb2, .fb2.zip) (#128) * Comic book archive (.cbr, .cbz, .cbt, .cb7) (#254) * Plain text (.txt) (#226) * Unpacked EPUB files Layout: * Option to set maximum page width (#192) * The "Automatic" layout will now show four columns when the page width is wide (#257) Image viewer: * Improved image viewer, with new shortcuts and the ability to rotate (#299) and invert images * Option to disable image viewer, or to open images on double, middle, or right click (#315) Text-to-speech: * Improved text-to-speech configuration UI * Ability to set text-to-speech voice based on book language (#134) Annotations * Import annotations from JSON * Search in annotations * Annotations are now sorted in the same order as they appear in the book (#318) * "Allow Unsafe Content" now only enables JavaScript; external content will no longer be loaded. This is an important security fix. If you are running an old version of Foliate and cannot upgrade, you should disable "Allow Unsafe Content". * WebKit processes are now sandboxed Other featues and fixes: * Improved support for vertical and right-to-left books * Support for StarDict dictionaries (#302) (requires new optional dependency sdcv) * Fixed current location not preserved when resizing (#152, #204) * Fixed auto-hiding header bar under some themes (#316) * Command-line options for showing version and adding books to library * Option to clear or disable cache * When an HTML page contains invalid self-closing anchor tags, it is now parsed as XHTML (#275, #288) Technical changes: * Foliate now stores file locations in ~/.local/share/com.github.johnfactotum.Foliate/library/uri-store.json, and saves book covers to ~/.cache/com.github.johnfactotum.Foliate. Both can be disabled. * New optional dependency tracker (gir1.2-tracker-2.0 on Debian based distributions), which can be used to get file locations. * New optional dependency libhandy (gir1.2-handy-0.0). It's not absolutely required, but installing it would make the experience better on larger as well as smaller screens. * To open remote files, Foliate now optionally depends on libsoup (gir1.2-soup-2.4). Foliate now bundles two additional libraries: * libarchivejs, which is MIT licensed. It is a WASM port of the popular libarchive C library. * crypto-js, which is MIT licensed. The MD5 module is used to generate identifiers for files that don't have unique identifiers.
Upstream Enhancements: * Detect future Intel AVX/AMX features #128 * Add support for Tiger Lake and Sapphire rapids Intel microarchitectures #127 * Update features for AArch64 to Linux 5.8 #126 * AVX-512 FMA count detection #120 Port Changes: * Add license file * Change libcpu_features to a shared library PR: 253037 Submitted by: yuri@
Converting old package to 2.3 structure.