Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python / linter versions for development #26

Merged
merged 5 commits into from
Sep 30, 2022

Conversation

bonprosoft
Copy link
Collaborator

@bonprosoft bonprosoft commented Sep 18, 2022

Sorry for such a big PR πŸ™‡β€β™‚οΈ

I upgraded the linter versions for the pysen development to the latest ones.

@bonprosoft bonprosoft changed the base branch from fix/ci-error-py37 to main September 25, 2022 10:47
@bonprosoft bonprosoft marked this pull request as ready for review September 25, 2022 10:47
Comment on lines +21 to +28
[[tool.pysen.lint.mypy_targets]]
paths = ["examples/advanced_example"]
[[tool.pysen.lint.mypy_targets]]
paths = ["examples/simple_package"]
[[tool.pysen.lint.mypy_targets]]
paths = ["examples/plugin_example"]
[[tool.pysen.lint.mypy_targets]]
paths = ["examples/sync_cmdclass_pyproject"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mypy 0.800+ changes the way to find target sources, I updated this section as described in our FAQ https://github.com/pfnet/pysen#frequently-asked-questions .

@bonprosoft bonprosoft changed the title Upgrade linter versions for development Upgrade Python / linter versions for development Sep 25, 2022
Copy link
Collaborator

@sergeant-wizard sergeant-wizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bonprosoft bonprosoft added chore Refactoring or non bug fixes no-compat-py No backward compatibility in Python interface labels Sep 29, 2022
@bonprosoft bonprosoft removed the no-compat-py No backward compatibility in Python interface label Sep 29, 2022
@bonprosoft
Copy link
Collaborator Author

@sergeant-wizard Thank you for your review! I reverted some of the changes to keep backward compatibility. PTAL πŸ™‡β€β™‚οΈ
4c2c2db

Copy link
Collaborator

@sergeant-wizard sergeant-wizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bonprosoft bonprosoft merged commit 571475c into main Sep 30, 2022
@bonprosoft bonprosoft deleted the fix/upgrade-lint-versions branch September 30, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactoring or non bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants