Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python 3.10 test #18

Merged
merged 4 commits into from
May 21, 2022
Merged

add python 3.10 test #18

merged 4 commits into from
May 21, 2022

Conversation

hirosassa
Copy link
Contributor

related to #15

I added Python 3.10 entry on supported Python classifier and tests workflow.

hirosassa
hirosassa commented Apr 23, 2022
View reviewed changes
assets/Dockerfile
@@ -5,9 +5,10 @@ COPY --from=python:3.6.13-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.7.10-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.8.8-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.9.2-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.10.4-alpine3.14 /usr/local/ /usr/local/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ask] There's no alpine3.13 images of Python 3.10 on Docker Hub.
Which image should I use here?

https://hub.docker.com/_/python?tab=tags

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok to use alpine 3.14. Can you update all images to 3.14?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in f698192

hirosassa
hirosassa commented Apr 29, 2022
View reviewed changes
tox.ini

[testenv]
deps =
pytest >=5.4.0,<6.0.0
pytest >=6.2.5,<7.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to upgrade pytest for python 3.10

ref: https://stackoverflow.com/questions/69528842/an-error-while-trying-to-execute-tests-on-python-3-10-with-pytest

assets/Dockerfile
@@ -5,9 +5,10 @@ COPY --from=python:3.6.13-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.7.10-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.8.8-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.9.2-alpine3.13 /usr/local/ /usr/local/
COPY --from=python:3.10.4-alpine3.14 /usr/local/ /usr/local/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in f698192

@bonprosoft bonprosoft added the chore Refactoring or non bug fixes label Apr 30, 2022
bonprosoft
bonprosoft reviewed May 1, 2022
View reviewed changes
assets/Dockerfile Outdated Show resolved Hide resolved
@bonprosoft
Copy link
Collaborator

bonprosoft commented May 1, 2022 •
edited
Loading

Thank you for the updates!
I've built the image and pushed it to quay.io.

pysen/.github/workflows/pysen-test.yml

Lines 12 to 13 in b227e2c

container:
image: quay.io/pysen/pysen-test@sha256:e6ecc68fda873bf269de16cbed734a627232b88cbdf7054c0520a31a57439738

Could you please change the image hash to a37dbee9ecc51ee5240deb275001a459ec177eb4e7b3666ae00088db102c6b9d?

diff --git a/.github/workflows/pysen-test.yml b/.github/workflows/pysen-test.yml
index 87778d5..55bb3a1 100644
--- a/.github/workflows/pysen-test.yml
+++ b/.github/workflows/pysen-test.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-20.04
     timeout-minutes: 15
     container:
-      image: quay.io/pysen/pysen-test@sha256:e6ecc68fda873bf269de16cbed734a627232b88cbdf7054c0520a31a57439738
+      image: quay.io/pysen/pysen-test@sha256:a37dbee9ecc51ee5240deb275001a459ec177eb4e7b3666ae00088db102c6b9d
     steps:
     - uses: actions/checkout@v2
       with:

@hirosassa
Copy link
Contributor Author

@bonprosoft Sorry for keeping you waiting. I updated the image hash.

@bonprosoft bonprosoft mentioned this pull request May 14, 2022
Merged
@bonprosoft
Copy link
Collaborator

bonprosoft commented May 14, 2022 •
edited
Loading

I'm so sorry for my late response.

The CI job for the latest commit 37edfda fails because of the git issue

I fixed the issue in #19, so could you rebase this branch from the latest main?
Also, I updated the pysen-test workflow to build the docker image on each CI job, which means we don't manage the docker image hash on the workflow file anymore.
Could you please revert the change 37edfda?

I'm sorry to trouble you.

@hirosassa
Copy link
Contributor Author

@bonprosoft Thanks for the reply! I applied it!

bonprosoft
bonprosoft approved these changes May 15, 2022
View reviewed changes
Copy link
Collaborator

@bonprosoft bonprosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!!

@bonprosoft bonprosoft requested a review from Hakuyume May 15, 2022 10:44
@bonprosoft
Copy link
Collaborator

@Hakuyume friendly ping

Hakuyume
Hakuyume approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonprosoft bonprosoft merged commit e564d72 into pfnet:main May 21, 2022
@bonprosoft
Copy link
Collaborator

@hirosassa Thank you for your contribution!!

@hirosassa hirosassa deleted the py310 branch May 21, 2022 22:13
@aoirint aoirint mentioned this pull request Apr 15, 2023
Merged
3 tasks
This was referenced Apr 26, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hakuyume Hakuyume Hakuyume approved these changes

@bonprosoft bonprosoft bonprosoft approved these changes

Assignees
No one assigned
Labels
chore Refactoring or non bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hirosassa @bonprosoft @Hakuyume