Force lint extras to use older click #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonprosoft
approved these changes
Apr 19, 2022
|
@Hakuyume release-drafter にそのままPRタイトルを使いたいので、タイトルをもう少しだけ descriptive にしてもらっても良いでしょうか？具体的には「 |
|
これでどうですか |
|
完璧です、ありがとうございます！ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
psf/black#2964 にあるように最新のclickでは古いblackが動作しない問題への対処です。
問題になるのは
pysen[lint]を使ってinstallしたときで、blackは古いversionが入る一方でclickは最新版が入ります (black側でclickの上限を制限していないため)。pysen[lint]でinstallするときにclickのversionを制限することで不整合が起きないようにしました。別の解決策としてblackの制限を緩めるというのもありますが、コードの変更や動作確認の手間が最小になるこちらの方法をとりました。
blackあるいはclickの最新版を使いたいユーザーは
extras_requireを使わないという方法があるので大きな問題にはならないという認識です。