Enable LINK_STATIC_LIBPROTOBUF option on MINGW #83
Conversation
This is because protobuf-2.6.1 is too old that bundled config.guess cannot detect MINGW+MSYS2 environment.
There was a problem hiding this comment.
Thanks! I'd like to note that the statically linked binary still requires external libstdc++ at the moment because mkldnn requires it. I'm waiting for mkldnn's static linking support. Do you want to merge it anyway?
| set(PROTOBUF_URL "https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOBUF_VERSION}/protobuf-${PROTOBUF_VERSION}.tar.gz") | ||
| set(PROTOBUF_HASH MD5=f3916ce13b7fcb3072a1fa8cf02b2423) | ||
| if(UNIX OR MINGW) | ||
| set(PROTOBUF_VERSION_STATIC "3.6.1") |
There was a problem hiding this comment.
I faced this issue when using 3.6.1 in my environment (3.5.1 seems to work). Could you check that built binaries work in your environment?
There was a problem hiding this comment.
Hmm, 3.6.1 seems to work in Ubuntu 16.04.
There was a problem hiding this comment.
Yes, menoh_test succeeded on Travis-CI and Appveyor, but I didn't tested it on other environments.
BTW:
If a desirable version of protobuf is changed, I will update PR #82 and rebase this PR on top of it.
|
Yes, I have noticed that |
|
Thanks! |
This PR enables
LINK_STATIC_LIBPROTOBUFoption on MINGW and adds a AppVeyor job for building a binary that statically linkslibprotobuf,libstdc++, andlibgcc.This PR is intended to be merged after #82 is merged, since this branch is forked from that branch.