Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Added a few new functionalities #3

Closed
wants to merge 5 commits into from

Conversation

HristoMohamed
Copy link

Hello,

I added a few new functionalities to your module, because they were needed at my site.
Now appdefaults is implemented and the realm supports v4_name converts.

Cheers,
Hristo

@riton
Copy link

riton commented Oct 28, 2014

👍 , those functionalities would be very welcome

@pfmooney
Copy link
Owner

Sorry folks, I'm not in a position where I can verify/test changes like this anymore.
Fork away if you want to run with it.

@pfmooney pfmooney closed this Oct 29, 2014
@riton
Copy link

riton commented Oct 29, 2014

Oh :-(, bad news.
@pfmooney, thanks for your work !

So if this module is no longer actively maintained, at CC-IN2P3 we've done a fork.
We'll apply this patch and maintain the forked version.

@riton
Copy link

riton commented Oct 29, 2014

@pfmooney, Maybe that you should also remove the module from the puppet-forge or mark this as abandoned ?
If you do so, CC-IN2P3 could publish the patched and supported version (while adding credits for your work of course).
This could help puppet-forge users to easily find their way to the actively supported version ? What do you think ?
Of course we should sync our actions and we'll first publish the patched version to the forge. We'll just increase your version number just like you would have done.

@HristoMohamed
Copy link
Author

At CERN's LHCb Online site we are also using the module with the changes I have made without running into any trouble.
@riton I do agree that an updated version should be posted to the forge!

@riton
Copy link

riton commented Oct 29, 2014

@HristoMohamed , @pfmooney I've created ccin2p3#1 for the last checks before I release it and publish it to the puppet-forge. Any comment will be greatly appreciated.
@pfmooney, thanks again for your work.

@pfmooney
Copy link
Owner

Once it's published, I'll updated my readme to point at your repo.

Cheers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants