Decode url content if on Python 3 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Before I merge this in, have you filled out Google's contributor license agreement? |
|
@pferate yes, I have. |
|
Thanks @chacken! Just need to check with @maxwell-k before I merge the PR. |
|
Whoops, I responded to this thinking it was a reply to my pull. My mistake. |
|
No worries. Thanks for your pull. Hopefully this branch can make it into the main branch soon. |
|
Yes I have; I signed on Sunday :-) Thanks for the speedy response! |
pferate
added a commit
that referenced
this pull request
Jan 28, 2015
Merging PR. Decode url content if on Python 3
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight improvement over @chacken's pull request #1 because it also supports Python 2.6 and 2.7 using the same style of test as google/oauth2client. Credit to him for spotting the fix!