Make sure PexInfo is isolated from os.environ.
#711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change a `PexInfo` constructed with pexrc files ignored would be subject to mutation through the side-effects of later `os.environ` mutation. Guard against this by consistently copying the environment the `PexInfo` is constructed with and add tests that ensure the guard works. Noticed working pex-tool#710.
stuhood
approved these changes
Apr 21, 2019
Eric-Arellano
approved these changes
Apr 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change a
PexInfoconstructed with pexrc files ignoredwould be subject to mutation through the side-effects of later
os.environmutation. Guard against this by consistently copying theenvironment the
PexInfois constructed with and add tests that ensurethe guard works.
Noticed working #710.