Support de-vendoring for installs. #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that pex vendors setuptools and wheel, we build / install sdists with potentially fragile import semantics for these two distributions. In particular, we trip up against this when trying to build cryptography. Robustify installs by de-vendoring setuptools and wheel when used in an install context. In order to support de-vendoring make the method of import conditional on an environment variable instead of attempting to re-write vendored imports at runtime. Fixes pex-tool#661
|
Reviewers: the 3 commits can bew reviewed seperately and the 1st commit was automatically generated via |
Remove some now unused code, add docs, fix doc typos.
|
Alright - hands-off from me with the last cleanup commit. Ignoring the 1st machine-generated commit things stand at: |
Eric-Arellano
approved these changes
Feb 7, 2019
TansyArron
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that pex vendors setuptools and wheel, we build / install sdists with
potentially fragile import semantics for these two distributions. In
particular, we trip up against this when trying to build cryptography.
Robustify installs by de-vendoring setuptools and wheel when used in an
install context. In order to support de-vendoring make the method of
import conditional on an environment variable instead of attempting to
re-write vendored imports at runtime.
Fixes #661