Follow PEP 425 suggestions on distribution preference. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zmanji : Looks like there is a style issue on the first shard... would you mind fixing that? Thanks! |
PEP 425 describes how a single interpreter on a platform can support many tags and a single package might have many distributions to satisfy those supported tags [0]. It describes a tie breaking mechanism: > Sometimes there will be more than one supported built distribution for a > particular version of a package. For example, a packager could release a > package tagged cp33-abi3-linux_x86_64 that contains an optional C extension > and the same distribution tagged py3-none-any that does not. The index of the > tag in the supported tags list breaks the tie, and the package with the C > extension is installed in preference to the package without because that tag > appears first in the list. pex lacks this tie breaking logic currently and it is the root cause of issue #639. To address this issue, I have enhanced the resolver's sorter to deprioritize packages that support the 'any' platform. [0]: https://www.python.org/dev/peps/pep-0425/#id1
|
@stuhood I believe it should pass now. For reference the |
jsirois
approved these changes
Jan 7, 2019
| @classmethod | ||
| def package_platform_tag_precedence(cls, package): | ||
| # Give all non 'any' tags higher precedence | ||
| supported_tags = package.supported_tags or [] |
There was a problem hiding this comment.
Thanks - this all looks great. The existing supported_tags property for BinaryPackage is unsuitable for complete sorting, but this is a step forward - at least platform specific packages now win over non. I've filed #642 to track fixing the rest.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 425 describes how a single interpreter on a platform can support many
tags and a single package might have many distributions to satisfy those
supported tags. It describes a tie breaking mechanism:
pex lacks this tie breaking logic currently and it is the root cause of
issue #639.
To address this issue, I have enhanced the resolver's sorter to deprioritize
packages that support the 'any' platform.