-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pex force local to handle PEP 420. #613
Conversation
2301eab
to
11f1886
Compare
Rebased against master now that vendoring change is in. This is just a CI burn, one more cleanup pass and I'll ping reviewers for another look. |
Previously, pex would blow up trying to adjust import paths if a PEP-420 implicit namespace package was encountered. Add a test of the path adjustment functionality both to confirm it was needed (it was) and that the fix technique works with all forms of namespace packages by only assuming they support `append`. To support all this, work around a pypy zipimporter bug: https://bitbucket.org/pypy/pypy/issues/1686 and, as a side-effect, eliminate our CI workaround for the pypy unit test shard. Fixes pex-tool#598 Fixes pex-tool#497
Alright - ready for re-review. Thanks again in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great to see PEP 420 support! Thanks for adding this.
Noting the OSX errors look like the classic, befuddling
|
…pypy zipimporter workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great. This is a very high quality PR. Thanks John! 🎉
Thanks for the reviews and suggestions folks! Green and merging. |
Previously, pex would blow up trying to adjust import paths if a PEP-420
implicit namespace package was encountered. Add a test of the path
adjustment functionality both to confirm it was needed (it was) and that
the fix technique works with all forms of namespace packages by only
assuming they support
append
.Fixes #598