Filter top-level requirements against env markers. #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only transitive requirements were filtered. Fixes pex-tool#456
jsirois
force-pushed
the
issues/456/complete
branch
from
3064d9d to
a123fda
Compare
|
FYI: The miss this fixes was discovered upgrading pants to pex 1.5.0 and killing blacklists here: pantsbuild/pants#6613 |
Closed
Eric-Arellano
approved these changes
Oct 10, 2018
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Nov 3, 2018
In pex-tool#582 and pex-tool#592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes pex-tool#615.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Nov 3, 2018
In pex-tool#582 and pex-tool#592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes pex-tool#615.
jsirois
added a commit
that referenced
this pull request
Nov 4, 2018
In #582 and #592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes #615.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only transitive requirements were filtered.
Fixes #456
Fixes #122