Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow the env marker test. #578

Merged
merged 1 commit into from
Oct 5, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions tests/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -876,21 +876,13 @@ def test_platform_specific_egg_resolution_matching():


@pytest.mark.skipif(NOT_CPYTHON27)
def test_jupyter_appnope_env_markers():
# NB: jupyter 1.0.0 does not properly pin its dep graph and both ipykernel and ipython support
# python 3 only post 5 and 6 respectively; so we add those deps explictly only to constrain them
# low such that they support python 2.7 for this test. We also pin jupyter's unconstrained dep on
# jupyter_console low to avoid a conflict with ipython on prompt-toolkit.
def test_ipython_appnope_env_markers():
res = run_pex_command(['--disable-cache',
'jupyter==1.0.0',
'jupyter_console<5.4',
'ipykernel<5',
'ipython<6',
'-c', 'jupyter',
'ipython==5.8.0',
'-c', 'ipython',
'--',
'--version'])
res.assert_success()
assert len(res.output) > 4


# TODO: https://github.com/pantsbuild/pex/issues/479
Expand Down