-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PEX environment setup. #531
Conversation
With the new test added but the fix not applied, the test failed like so:
|
Hrm. Locally I was seeing the errors of the form seen in CI - randomly :(:
On successful runs I could copy the |
OK - this exposes a longstanding bug with extras - order is important when importing setuptools. If wheel is not on the sys.path when it is imported, no wheel distutils commands will be discovered. I'll try a fix to get CI green and then break that out as a seperate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, however I hit a test failure on the py36-requests environment:
**** Failed to install tmps18ib62q (caused by: NonZeroExit("received exit code 1 during execution of `['/Users/clivingston/workspace/pex/.pyenv_test/versions/2.7.10/bin/python2.7', '-', 'bdist_wheel', '--dist-dir=/var/folders/7n/x4k4tqh94k9gwm61g046m2340000gn/T/tmp39eob7fs']` while trying to execute `['/Users/clivingston/workspace/pex/.pyenv_test/versions/2.7.10/bin/python2.7', '-', 'bdist_wheel', '--dist-dir=/var/folders/7n/x4k4tqh94k9gwm61g046m2340000gn/T/tmp39eob7fs']`",)
):
stdout:
stderr:
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
error: invalid command 'bdist_wheel'
I suspect this is specific to my machine, but shouldn't tox be installing wheel for this run?
@CMLivingston did your test include 2ec7c0b? That has the fix for the FWIW: without the fix, running |
Nope, just pulled and it now works for me! Thanks. |
OK great. Thanks for giving this a spin @CMLivingston. I'll split that unrelated fix off to its own PR - deserves a test of its own. I'll then rebase this after that PR hits master. |
And the |
Previously, if a PEX had a custom interpreter, it was not threaded through to the environments it activated. Add a test that the designated interpreter is used. Fixes pex-tool#522
Previously, if a PEX had a custom interpreter, it was not threaded
through to the environments it activated. Add a test that the
designated interpreter is used.
Fixes #522