Fix PythonInterpreter caching and ergonomics.
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PythonInterpreter.from_binary` method now caches by a full stable key over all input parameters fixing previously order-dependent caching. In addition, an `include_site_extras` argument is added to allow the caller to request a bare interpreter (by passing `False`) with none of the extra distributions installed in the interpeter `site-packages` directory. Fixes pex-tool#509 Fixes pex-tool#510
Some tests require this.
kwlzn
approved these changes
Jun 16, 2018
pex/interpreter.py
Outdated
| :param binary: | ||
| :param path_extras: | ||
| :param include_site_extras: | ||
| :return: |
There was a problem hiding this comment.
missing values for docstrings here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PythonInterpreter.from_binarymethod now caches by a full stablekey over all input parameters fixing previously order-dependent caching.
In addition, an
include_site_extrasargument is added to allow thecaller to request a bare interpreter (by passing
False) with none ofthe extra distributions installed in the interpeter
site-packagesdirectory.
Fixes #509
Fixes #510