-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wheel support in pex. #388
Merged
Merged
Changes from 3 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f7b9dd7
Improve wheel support in pex.
MarkChuCarroll 533e641
Rewrite the pex wheel fix, using the wheel installer.
MarkChuCarroll bac461a
Clean up.
MarkChuCarroll cb5da41
Fix some path confusion.
MarkChuCarroll 5a9575c
Switch to use os.walk instead of os.path.walk to increase compatibili…
MarkChuCarroll 027635c
Tests pass locally; trying to get them to pass in CI.
MarkChuCarroll bb4088f
Update the wheel script finder so that it works during both pex gener…
MarkChuCarroll 75014cf
Move "wheelfile" import so it only gets loaded during pex generation.
MarkChuCarroll 95c01e1
Fix isort issue.
MarkChuCarroll 86b420c
Add an explicit dependency on "wheel" to setup.py's test deps.
MarkChuCarroll 0e45922
Update requirements to pull wheel in for py26.
MarkChuCarroll e63644a
Run isort to fix import sort issues.
MarkChuCarroll 1cd5e1b
Add a bypass of the wheel install code for Python 2.6.
MarkChuCarroll 1637e5a
Add a bypass of the wheel install code for Python 2.6.
MarkChuCarroll e66ade4
Another try at fixing the build.
MarkChuCarroll 2ed5338
Another try at fixing the build.
MarkChuCarroll 02a9e61
Try fixing the "skipif" flag.
MarkChuCarroll 5625240
Add "skipif" to the texs_pex_builder_wheeldep for Python 2.6
MarkChuCarroll 570c754
Duh.
MarkChuCarroll bb3e066
Update isort.
MarkChuCarroll fcdf3fd
Another try at the import issue.
MarkChuCarroll 031463c
Address some review comments.
MarkChuCarroll 2701d98
isort.
MarkChuCarroll d84f211
Fix the 26 test.
MarkChuCarroll 1100e3f
Keep trying to fix the stupid isort.
MarkChuCarroll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,6 +61,7 @@ | |
'twitter.common.lang>=0.3.1,<0.4.0', | ||
'twitter.common.testing>=0.3.1,<0.4.0', | ||
'twitter.common.dirutil>=0.3.1,<0.4.0', | ||
'wheel==0.29.0', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that WHEEL_REQUIREMENT should now be in install_requires |
||
'pytest', | ||
], | ||
entry_points = { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of
pex.common.safe_mkdtemp
is preferred.