More fixes for windows #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping :) |
|
Ping. |
|
Would this be easier to review if I made separate PRs for each commit? That would be fairly easy to do since they're not really dependent on each other. |
This also fixes handling of weird characters in the filename (e.g. test#binary.pex is no longer a url fragment).
Resolve the path before relativizing it & always use / as the path separator in the hash.
The egg metadata code would incorrectly try to munge a windows path as a posix one. Instead treat the zip_pre[fix] as OS-dependent and normalize only the suffix.
tar isn't as readily available; zip works fine.
The main points of note are: - Use temporary_filename() to get a filename without any open handles (Windows will not let you unlink a file that has open handles). - Get rid of NamedTemporaryFile/temporary_file in lieu of using our helper in util. - Pexs aren't executable on windows directly - run them as `python ...` - Skip soft/hard link tests on windows - Small fixes w.r.t. / vs \ and s/\r//g
mikekap
force-pushed
the
windows_pull
branch
from
436ee1b to
f03ce12
Compare
|
Fixed the comments; PTAL @ the link commit, since it involved some urllib.unquote additions (which I think make Link.py even more correct). Almost feels like link.py should be open-sourced on it's own :P |
|
lgtm! 👍 |
|
thanks for the PR @mikekap - I'll get a release out soon so folks can consume this via pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all the tests pass.
One thing I'm not sure about is in the first commit - perhaps we should do away with Link.local_path & make Link.path do the proper thing? I don't think there's a single user of Link.path that uses it for real urls. Let me know what you think.