Fix --requirements-pex.
#1684
Merged
Fix --requirements-pex.
#1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch from sha1 to sha256 hashes in pex-tool#1661 did not cover this feature. Simplify and use the existing machinery to get at a PEX's distributions. Fixes pex-tool#1683
jsirois
commented
Mar 22, 2022
| "-o", | ||
| app_pex, | ||
| ] | ||
| ).assert_success() |
There was a problem hiding this comment.
This reproduces #1683 (comment) before the fix.
This is correct since resolving picks the dists compatible with the current interpreter, but we want all the dists to support multiplatform cases.
benjyw
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch from sha1 to sha256 hashes in #1661 did not cover this
feature. Simplify and use the existing machinery to get at a PEX's
distributions.
Fixes #1683