Normalize all names in ResolvableSet. Fixes #147. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +58,10 @@ def merge(self, other): | |||
|
|
|||
|
|
|||
| class _ResolvableSet(object): | |||
| @classmethod | |||
There was a problem hiding this comment.
why @classmethod here vs @staticmethod?
There was a problem hiding this comment.
I just generally always use classmethods instead of staticmethods to allow for future subclassing/testing. For example, we could write an implementation like so:
class BuggyResolvableSet(_ResolvableSet):
@classmethod
def normalize(cls, name):
return nameand then assert that it fails when running the same test suite as the regular implementation.
As it stands, we're subclassing it nowhere and it's an internal class so it doesn't really give us any leverage over a staticmethod but why be inconsistent.
|
LGTM - one comment. |
|
LGTM |
wickman
added a commit
that referenced
this pull request
Aug 12, 2015
Normalize all names in ResolvableSet. Fixes #147.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.