Make Enums sortable. #1470
Merged
Make Enums sortable. #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used for error messages when introducing sortability to `Enum` and in lock file parsing. Work towards pex-tool#1401 and pex-tool#1414.
Upcoming lock file work will benefit from this. Instead of just sorting by the string value of an `Enum.Value`, introduce an ordinal to sort by and take the opportunity to dry up the values method. Work towards pex-tool#1401 and pex-tool#1414.
jsirois
commented
Sep 25, 2021
| @@ -71,7 +71,8 @@ commands = | |||
| [testenv:typecheck] | |||
| deps = | |||
| attrs==21.2.0 # This version should track the version in pex/vendor/__init__.py. | |||
| mypy==0.800 | |||
| mypy[python2]==0.910 | |||
There was a problem hiding this comment.
I mistakenly thought this upgrade was needed to support @total_ordering used in Enum.Value in this PR.
stuhood
approved these changes
Sep 25, 2021
…/1401/Enum/simplify-and-sortable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming lock file work will benefit from this. Instead of just sorting
by the string value of an
Enum.Value, introduce an ordinal to sort byand take the opportunity to dry up the values method.
Work towards #1401 and #1414.