Extract URLFetcher for reuse with lock files. #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock file generation will need to download and hash dists when their hashes are not presented in PEP 503 link fragments and we'll also need to download dists directly if we optimize the resolving from a lock file case when the lock file contains urls ala PEP-665. Work towards pex-tool#1401.
jsirois
commented
Aug 19, 2021
| proxies = {protocol: network_configuration.proxy for protocol in ("http", "https")} | ||
|
|
||
| handlers = [ProxyHandler(proxies), HTTPSHandler(context=ssl_context)] | ||
| if handle_file_urls: |
There was a problem hiding this comment.
The only changes to this class besides being moved from requirements.py to here are:
- Drop "ftp" from the proxy protocols above since we don't install the FtpHandler / never intended to support plaintext FTP.
- Add optional FileHandler support which will be needed / useful for handling --find-links "downloads" from local find-links repos in a way that keeps manual dist hashing code uniform / simpler.
jsirois
commented
Aug 19, 2021
| @@ -108,13 +108,15 @@ def exec_function(ast, globals_map): | |||
|
|
|||
| from urllib.error import HTTPError as HTTPError | |||
| from urllib.request import build_opener as build_opener | |||
| from urllib.request import FileHandler as FileHandler | |||
There was a problem hiding this comment.
N.B.: On general Pex requirements for the uninitiated:
- It still supports Python 2.7
- It ships as both a distribution on PyPI and a Pex PEX via github releases.
2 makes it extremely unattractive to vendor requests since its (indirectly) platform-specific and the shipped Pex PEX - which is currently pure python - would need to grow multiplatform support that included {linux wheels, and two flavors of macOS wheels} X {2.7, 3.5...3.9}.
Eric-Arellano
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock file generation will need to download and hash dists when their
hashes are not presented in PEP 503 link fragments and we'll also need
to download dists directly if we optimize the resolving from a lock file
case when the lock file contains urls ala PEP-665.
Work towards #1401.