Bytecode compile using the correct interpreter. #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix the `_ResolvableSet` was blind to any packages built and cached in earlier loops of a complex resolve. This change makes the resolvable set aware by tracking built packages and replacing unbuilt packages with them in the resolvable set. Failing tests were added pass with the fixes.
Also kill an unused import caught by twitterstyle.
Previously a PEXBuilder with a custom interpeter would not use it to bytecode compile sources when building a pex. This could lead to errors when the current interpreter and the target interpreter spanned breaking language changes. Kill the CodeMarshaller which has only its marshalling half used in favor of using py_compile from the stdlib in the new interpreter-sensitive Compiler class. Additionally, actually compile all PEXBuilder source including any generated __init__.pys, the generated __main__.py and everything in the _pex/ bootstrap.
|
This is part of addressing pantsbuild/pants#1658 |
|
This addresses #127 |
Also kill unused compiler code and improve test readability.
…is/resolver_rounds/fix
There are none of these today, but there could conceivably resources in the bootstrap packages.
…is/cross_compile/fix
|
Submitted @ ac3c7f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a PEXBuilder with a custom interpeter would not use it to
bytecode compile sources when building a pex. This could lead to errors
when the current interpreter and the target interpreter spanned breaking
language changes.
Kill the CodeMarshaller which has only its marshalling half used in
favor of using py_compile from the stdlib in the new
interpreter-sensitive Compiler class.
Additionally, actually compile all PEXBuilder source including any
generated
__init__.pys, the generated__main__.pyand everything in the_pex/bootstrap.https://rbcommons.com/s/twitter/r/2350/