Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pex 1.0 #100

Merged
merged 2 commits into from
Jun 1, 2015
Merged

pex 1.0 #100

merged 2 commits into from
Jun 1, 2015

Conversation

wickman
Copy link
Contributor

@wickman wickman commented Apr 18, 2015

This is just minor CHANGES.rst cleanup before minting 1.0. But I'd like to take this opportunity to get feedback. Is now the right time to cut 1.0? Any features we're missing? Don't like the semver contract?

@warsaw
Copy link
Contributor

warsaw commented Apr 21, 2015

I've been playing a bit with master (not wickman/1.0 atm) and it looks pretty good w.r.t. use in creating Python snaps for Ubuntu core. E.g.:

$ pex -o world.pex --python-shebang=/usr/bin/python3 --disable-cache -c world world

is a much nicer command than what I had been using.

One question comes to mind though: given that my setup.py for world has only one entry point:

    entry_points={
        'console_scripts': ['world = worldlib.__main__:main'],
        },

is it possible for pex to use that automatically if no -c option is given? That doesn't seem to be the case currently. It just means one less thing that has to be specified when building some snaps. (IIRC, you were mentioning that pex could build multiple pex files if there were multiple console_scirpts defined.)

@wickman
Copy link
Contributor Author

wickman commented Apr 21, 2015

I don't think so. First, you can specify any number of resolvables via the command line or via -r, so at that point things become ambiguous. Second, not everyone wants to build a pex file with an entry point specified (instead they just want pex-as-virtualenv.) Maybe it makes sense for this to be the default behavior of bdist_pex (see #99).

@warsaw
Copy link
Contributor

warsaw commented Apr 21, 2015

Yeah, could be rather cool as bdist_pex. Okay, fair enough!

to semver insofar as backwards incompatible API changes will invoke minor version changes.

For users of the PEX API, it is recommended to add minor version ranges, e.g. ``pex>=1.0,<1.1``.
For users of the PEX CLI, major version ranges such as ``pex>=1,<2`` should be sufficient.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

wickman added a commit that referenced this pull request Jun 1, 2015
@wickman wickman merged commit 28e03d2 into pex-tool:master Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants