Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #790

Closed
2 tasks done
jsirois opened this issue Nov 14, 2019 · 2 comments · Fixed by #792
Closed
2 tasks done

Release 2.0.0 #790

jsirois opened this issue Nov 14, 2019 · 2 comments · Fixed by #792
Assignees
Labels

Comments

@jsirois
Copy link
Member

jsirois commented Nov 14, 2019

On the docket:

That one issue closes out a slew of others, partially documented in #686.

@jsirois jsirois self-assigned this Nov 14, 2019
@Eric-Arellano
Copy link
Contributor

Do we still want to flip the defaults to be --no-use-system-time and --no-compile for reproducible PEXes by default?

See the PR description #722 (comment), which claims:

We will default to --use-system-time for now to keep prior behavior, and then in a future release like 1.70 will switch over to default to reproducible builds.

This decision was made in #718.

@jsirois
Copy link
Member Author

jsirois commented Nov 14, 2019

Do we still want to flip the defaults to be --no-use-system-time and --no-compile for reproducible PEXes by default?

Sounds good. I'll send up a small PR for that presently.

jsirois added a commit to jsirois/pex that referenced this issue Nov 15, 2019
jsirois added a commit that referenced this issue Nov 15, 2019
@jsirois jsirois mentioned this issue Nov 20, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants