Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pex should not re-exec when the current interpreter satifies constraints #709

Closed
jsirois opened this issue Apr 21, 2019 · 1 comment · Fixed by #741
Closed

Pex should not re-exec when the current interpreter satifies constraints #709

jsirois opened this issue Apr 21, 2019 · 1 comment · Fixed by #741
Assignees
@jsirois
Labels
enhancement

Comments

@jsirois
Copy link
Member

jsirois commented Apr 21, 2019 •
edited
Loading

Currently Pex can re-exec against a new interpreter even when the current interpreter is on the PEX_PYTHON_PATH or PATH and matches any compatibility constraints. This should be avoided both for efficiency and to allow explicit control of the interpreter used to execute the pex.
@jsirois
Copy link
Member Author

jsirois commented Apr 21, 2019

Noticed working pantsbuild/pants#7591

@jsirois jsirois self-assigned this Apr 21, 2019
@jsirois jsirois mentioned this issue Apr 21, 2019
Merged
@jsirois jsirois mentioned this issue May 8, 2019
Merged
@jsirois jsirois mentioned this issue Jun 24, 2019
Closed
6 tasks
jsirois added a commit to jsirois/pex that referenced this issue Jun 24, 2019
@jsirois
Fixup pex re-exec during bootstrap.
c718d65 
Ensure `PEX_PYTHON` and `PEX_PYTHON_PATH` are actually scrubbed from the
environment of the pex process when re-exec'd fixing pex-tool#710. Also
uniformize re-exec interpreter selection to ensure that the current
interpreter is preferred when it meets any constraints fixing pex-tool#709.

Fixes pex-tool#709
Fixes pex-tool#710
@jsirois jsirois mentioned this issue Jun 24, 2019
Merged
jsirois added a commit to jsirois/pex that referenced this issue Jun 25, 2019
@jsirois
Fixup pex re-exec during bootstrap.
b67eafe 
Ensure `PEX_PYTHON` and `PEX_PYTHON_PATH` are actually scrubbed from the
environment of the pex process when re-exec'd fixing pex-tool#710. Also
uniformize re-exec interpreter selection to ensure that the current
interpreter is preferred when it meets any constraints fixing pex-tool#709.

Fixes pex-tool#709
Fixes pex-tool#710
jsirois added a commit that referenced this issue Jun 25, 2019
@jsirois
Fixup pex re-exec during bootstrap. (#741)
32e074c 
Ensure `PEX_PYTHON` and `PEX_PYTHON_PATH` are actually scrubbed from the
environment of the pex process when re-exec'd fixing #710. Also
uniformize re-exec interpreter selection to ensure that the current
interpreter is preferred when it meets any constraints fixing #709.

Fixes #709
Fixes #710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixup pex re-exec during bootstrap. jsirois/pex
1 participant
@jsirois