Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tox -evendor idempotency check to CI #650

Closed
jsirois opened this issue Jan 22, 2019 · 1 comment
Closed

Add tox -evendor idempotency check to CI #650

jsirois opened this issue Jan 22, 2019 · 1 comment
Assignees
@jsirois
Labels
enhancement

Comments

@jsirois
Copy link
Member

jsirois commented Jan 22, 2019

This will ensure we never check in modifications (beyond automated import re-writes) to vendored code.
@jsirois
Copy link
Member Author

jsirois commented Jan 22, 2019

Related to #646

@jsirois jsirois mentioned this issue Jan 22, 2019
Closed
@jsirois jsirois self-assigned this Jan 22, 2019
jsirois added a commit to jsirois/pex that referenced this issue Jan 22, 2019
@jsirois
Make tox -evendor idempotent.
70d718c 
This affords adding a CI check to ensure we never commit vendored code
with modifications beyond import re-writes.

Fixes pex-tool#649
Fixes pex-tool#650
@jsirois jsirois mentioned this issue Jan 22, 2019
Merged
jsirois added a commit that referenced this issue Jan 23, 2019
@jsirois
Make tox -evendor idempotent. (#651)
dfbc5db 
This affords adding a CI check to ensure we never commit vendored code
with modifications beyond import re-writes.

And for this first burn of the new CI check to go green, the edit of
vendored wheel code in 16cfd97 is undone by a fresh run of
`tox -evendor`.

Fixes #649
Fixes #650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois