Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair broken tests in master #463

Closed
kwlzn opened this issue May 11, 2018 · 9 comments
Closed

repair broken tests in master #463

kwlzn opened this issue May 11, 2018 · 9 comments
Assignees
Labels

Comments

@kwlzn
Copy link
Contributor

kwlzn commented May 11, 2018

when #461 broke travis status, a handful of test failures unfortunately leaked into master.

this ticket tracks repairing those failures to get master green again.

this travis run should reveal the breakage beyond #461: https://travis-ci.org/pantsbuild/pex/builds/377906298

@kwlzn kwlzn added the bug label May 11, 2018
@kwlzn
Copy link
Contributor Author

kwlzn commented May 11, 2018

lint fixes out here: #464

@kwlzn
Copy link
Contributor Author

kwlzn commented May 11, 2018

isort fixes out here: #465

@kwlzn
Copy link
Contributor Author

kwlzn commented May 12, 2018

a round of @CMLivingston fixes out here: #466

@kwlzn
Copy link
Contributor Author

kwlzn commented May 12, 2018

there are still at least two outstanding classes of issues that I can see in master.

  1. https://travis-ci.org/pantsbuild/pex/jobs/377947612#L434

  2. https://travis-ci.org/pantsbuild/pex/jobs/377947612#L244

@kwlzn
Copy link
Contributor Author

kwlzn commented May 12, 2018

potential fix for #1 out here: #468

@kwlzn
Copy link
Contributor Author

kwlzn commented May 12, 2018

#1 is fixed and I've added improved traceback logging for the pex integration testing to reveal a full traceback for #2, which shows:

https://travis-ci.org/pantsbuild/pex/jobs/378030033#L322

this seems to relate to locating setuptools for injection into the pex bootstrap payload, but only repros in CI.

@kwlzn
Copy link
Contributor Author

kwlzn commented May 13, 2018

cut #470 for the two straggler integration tests and will skip those for now.

@kwlzn
Copy link
Contributor Author

kwlzn commented May 14, 2018

@CMLivingston cut #474 to close #470

there's still some extreme flakiness in the pypy shard, will look into resolving that today.

@kwlzn
Copy link
Contributor Author

kwlzn commented May 14, 2018

#477 for the pypy issue and #478 for temporary relief. this should get master fully stable again.

kwlzn added a commit that referenced this issue May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant