Skip to content

Commit

Permalink
Narrow the env marker test. (#578)
Browse files Browse the repository at this point in the history
The jupyter dist is just a meta-dist with fully unconstrained deps on ~6
other dists. This test was added to test environment marker support in
pex, which ipython - not jupyter - leverages heavily.
  • Loading branch information
jsirois authored Oct 5, 2018
1 parent 751add2 commit 28bf694
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions tests/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -876,21 +876,13 @@ def test_platform_specific_egg_resolution_matching():


@pytest.mark.skipif(NOT_CPYTHON27)
def test_jupyter_appnope_env_markers():
# NB: jupyter 1.0.0 does not properly pin its dep graph and both ipykernel and ipython support
# python 3 only post 5 and 6 respectively; so we add those deps explictly only to constrain them
# low such that they support python 2.7 for this test. We also pin jupyter's unconstrained dep on
# jupyter_console low to avoid a conflict with ipython on prompt-toolkit.
def test_ipython_appnope_env_markers():
res = run_pex_command(['--disable-cache',
'jupyter==1.0.0',
'jupyter_console<5.4',
'ipykernel<5',
'ipython<6',
'-c', 'jupyter',
'ipython==5.8.0',
'-c', 'ipython',
'--',
'--version'])
res.assert_success()
assert len(res.output) > 4


# TODO: https://github.com/pantsbuild/pex/issues/479
Expand Down

0 comments on commit 28bf694

Please sign in to comment.