Skip to content

Commit

Permalink
Minimum setuptools version should be 20.3 so Requirement has specifie…
Browse files Browse the repository at this point in the history
…r attribute required by PR 355 (#391)

In #355 package.py was updated to assume that the Requirement class has the specifier attribute.

The specifier attribute wasn't added to the Requirement class until setuptools 20.3 pypa/setuptools@de4bdcf

The error when there is an older setuptools is

Exception message: Requirement instance has no attribute 'specifier'
  • Loading branch information
cheister authored and kwlzn committed May 26, 2017
1 parent d353e4c commit 0d01ba8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pex/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
# NB: If we upgrade to setuptools>=34 pex's bootstrap code in `PEXBuilder` will need an update to
# include the `packaging` package in the `.bootstrap/` code since we use
# `packaging.specifiers.SpecifierSet` - indirectly - through `pkg_resources.Requirement.specifier`.
SETUPTOOLS_REQUIREMENT = 'setuptools>=20.0,<34.0'
SETUPTOOLS_REQUIREMENT = 'setuptools>=20.3,<34.0'

WHEEL_REQUIREMENT = 'wheel>=0.26.0,<0.30.0'

0 comments on commit 0d01ba8

Please sign in to comment.