Migrate from FEST 2 to AssertJ, fixes dropwizard#493

In the future assertj-joda-time (http://joel-costigliola.github.io/assertj/assertj-joda-time.html) and
assertj-guava (http://joel-costigliola.github.io/assertj/assertj-guava.html) might also come in handy
for writing more concise tests for Dropwizard (which is using both, JodaTime and Google Guava).

docs/source/manual/testing.rst

@@ -89,7 +89,7 @@ Next, write a test for serializing a ``Person`` instance to JSON:
 .. code-block:: java
 
     import static io.dropwizard.testing.FixtureHelpers.*;
-    import static org.fest.assertions.api.Assertions.assertThat;
+    import static org.assertj.core.api.Assertions.assertThat;
     import io.dropwizard.jackson.Jackson;
     import org.junit.Test;
     import com.fasterxml.jackson.databind.ObjectMapper;
@@ -106,11 +106,11 @@ Next, write a test for serializing a ``Person`` instance to JSON:
         }
     }
 
-This test uses `FEST matchers`_ and JUnit_ to test that when a ``Person`` instance is serialized
+This test uses `AssertJ assertions`_ and JUnit_ to test that when a ``Person`` instance is serialized
 via Jackson it matches the JSON in the fixture file. (The comparison is done via a normalized JSON
 string representation, so whitespace doesn't affect the results.)
 
-.. _FEST matchers: https://code.google.com/p/fest/
+.. _AssertJ assertions: http://assertj.org/assertj-core-conditions.html
 .. _JUnit: http://www.junit.org/
 
 .. _man-testing-representations-deserialization:
@@ -123,7 +123,7 @@ Next, write a test for deserializing a ``Person`` instance from JSON:
 .. code-block:: java
 
     import static io.dropwizard.testing.FixtureHelpers.*;
-    import static org.fest.assertions.api.Assertions.assertThat;
+    import static org.assertj.core.api.Assertions.assertThat;
     import io.dropwizard.jackson.Jackson;
     import org.junit.Test;
     import com.fasterxml.jackson.databind.ObjectMapper;
@@ -141,7 +141,7 @@ Next, write a test for deserializing a ``Person`` instance from JSON:
     }
 
 
-This test uses `FEST matchers`_ and JUnit_ to test that when a ``Person`` instance is
+This test uses `AssertJ assertions`_ and JUnit_ to test that when a ``Person`` instance is
 deserialized via Jackson from the specified JSON fixture it matches the given object.
 
 .. _man-testing-resources:
@@ -157,7 +157,7 @@ loads a given resource instance in an in-memory Jersey server:
 
 .. code-block:: java
 
-    import static org.fest.assertions.api.Assertions.assertThat;
+    import static org.assertj.core.api.Assertions.assertThat;
     import static org.mockito.Mockito.*;
 
     public class PersonResourceTest {

dropwizard-assets/src/test/java/io/dropwizard/assets/AssetsBundleTest.java

@@ -12,7 +12,7 @@
 import javax.servlet.ServletRegistration;
 import java.net.URL;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.*;
 
 public class AssetsBundleTest {

dropwizard-auth/src/test/java/io/dropwizard/auth/CachingAuthenticatorTest.java

@@ -11,7 +11,7 @@
 import org.junit.Test;
 import org.mockito.InOrder;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.*;
 
 public class CachingAuthenticatorTest {

dropwizard-auth/src/test/java/io/dropwizard/auth/basic/BasicAuthProviderTest.java

@@ -19,8 +19,8 @@
 import javax.ws.rs.core.HttpHeaders;
 import javax.ws.rs.core.MediaType;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 
 
 public class BasicAuthProviderTest extends JerseyTest {

dropwizard-auth/src/test/java/io/dropwizard/auth/basic/BasicCredentialsTest.java

@@ -2,7 +2,7 @@
 
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class BasicCredentialsTest {
     private final BasicCredentials credentials = new BasicCredentials("u", "p");

dropwizard-auth/src/test/java/io/dropwizard/auth/oauth/OAuthProviderTest.java

@@ -19,8 +19,8 @@
 import javax.ws.rs.core.HttpHeaders;
 import javax.ws.rs.core.MediaType;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 
 public class OAuthProviderTest extends JerseyTest {
     static {

dropwizard-client/src/test/java/io/dropwizard/client/HttpClientBuilderTest.java

@@ -32,7 +32,7 @@
 import java.io.IOException;
 import java.lang.reflect.Field;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 

dropwizard-client/src/test/java/io/dropwizard/client/JerseyClientBuilderTest.java

@@ -25,8 +25,8 @@
 import java.lang.reflect.Type;
 import java.util.concurrent.ExecutorService;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 import static org.mockito.Mockito.*;
 
 public class JerseyClientBuilderTest {

dropwizard-configuration/src/test/java/io/dropwizard/configuration/ConfigurationFactoryFactoryTest.java

@@ -1,6 +1,6 @@
 package io.dropwizard.configuration;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import io.dropwizard.configuration.ConfigurationFactoryTest.Example;
 import io.dropwizard.jackson.Jackson;
 

dropwizard-configuration/src/test/java/io/dropwizard/configuration/ConfigurationFactoryTest.java

@@ -5,7 +5,7 @@
 import com.google.common.collect.Maps;
 import com.google.common.io.Resources;
 import io.dropwizard.jackson.Jackson;
-import org.fest.assertions.data.MapEntry;
+import org.assertj.core.data.MapEntry;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -17,8 +17,8 @@
 import java.io.File;
 import java.util.*;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 
 public class ConfigurationFactoryTest {
 

dropwizard-configuration/src/test/java/io/dropwizard/configuration/ConfigurationValidationExceptionTest.java

@@ -10,7 +10,7 @@
 import java.util.Locale;
 import java.util.Set;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.hamcrest.CoreMatchers.is;
 import static org.junit.Assume.assumeThat;
 

dropwizard-configuration/src/test/java/io/dropwizard/configuration/FileConfigurationSourceProviderTest.java

@@ -7,7 +7,7 @@
 
 import java.io.InputStream;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class FileConfigurationSourceProviderTest {
     private final ConfigurationSourceProvider provider = new FileConfigurationSourceProvider();

dropwizard-configuration/src/test/java/io/dropwizard/configuration/UrlConfigurationSourceProviderTest.java

@@ -7,7 +7,7 @@
 
 import java.io.InputStream;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class UrlConfigurationSourceProviderTest {
     private final ConfigurationSourceProvider provider = new UrlConfigurationSourceProvider();

dropwizard-core/src/test/java/io/dropwizard/ApplicationTest.java

@@ -4,7 +4,7 @@
 import io.dropwizard.setup.Environment;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class ApplicationTest {
     private static class FakeConfiguration extends Configuration {}

dropwizard-core/src/test/java/io/dropwizard/ConfigurationTest.java

@@ -7,7 +7,7 @@
 import io.dropwizard.logging.AppenderFactory;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class ConfigurationTest {
     private final Configuration configuration = new Configuration();

dropwizard-core/src/test/java/io/dropwizard/cli/CheckCommandTest.java

@@ -7,7 +7,7 @@
 import net.sourceforge.argparse4j.inf.Namespace;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verifyZeroInteractions;
 

dropwizard-core/src/test/java/io/dropwizard/cli/CliTest.java

@@ -12,7 +12,7 @@
 
 import java.io.ByteArrayOutputStream;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.*;
 
 public class CliTest {

dropwizard-core/src/test/java/io/dropwizard/cli/ServerCommandTest.java

@@ -14,8 +14,8 @@
 
 import java.io.IOException;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 

dropwizard-core/src/test/java/io/dropwizard/server/DefaultServerFactoryTest.java

@@ -1,6 +1,6 @@
 package io.dropwizard.server;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import io.dropwizard.configuration.ConfigurationFactory;
 import io.dropwizard.jackson.DiscoverableSubtypeResolver;
 import io.dropwizard.jackson.Jackson;

dropwizard-core/src/test/java/io/dropwizard/server/SimpleServerFactoryTest.java

@@ -3,7 +3,7 @@
 import io.dropwizard.jackson.DiscoverableSubtypeResolver;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class SimpleServerFactoryTest {
     @Test

dropwizard-core/src/test/java/io/dropwizard/setup/AdminEnvironmentTest.java

@@ -10,7 +10,7 @@
 import javax.servlet.ServletRegistration;
 import java.io.PrintWriter;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class AdminEnvironmentTest {
     private final MutableServletContextHandler handler = new MutableServletContextHandler();

dropwizard-core/src/test/java/io/dropwizard/setup/BootstrapTest.java

@@ -8,7 +8,7 @@
 
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class BootstrapTest {
     private final Application<Configuration> application = new Application<Configuration>() {

dropwizard-db/src/test/java/io/dropwizard/db/DataSourceFactoryTest.java

@@ -9,7 +9,7 @@
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class DataSourceFactoryTest {
     private final MetricRegistry metricRegistry = new MetricRegistry();

dropwizard-db/src/test/java/io/dropwizard/db/ManagedPooledDataSourceTest.java

@@ -6,8 +6,8 @@
 
 import java.sql.SQLFeatureNotSupportedException;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 
 public class ManagedPooledDataSourceTest {
     private final PoolProperties config = new PoolProperties();

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/AbstractDAOTest.java

@@ -10,7 +10,7 @@
 import java.io.Serializable;
 import java.util.List;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Matchers.anyString;
 import static org.mockito.Mockito.*;
 

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/HibernateBundleTest.java

@@ -15,7 +15,7 @@
 import org.junit.Test;
 import org.mockito.ArgumentCaptor;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.*;
 
 public class HibernateBundleTest {

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/JerseyIntegrationTest.java

@@ -26,8 +26,8 @@
 import javax.ws.rs.core.MediaType;
 import java.util.TimeZone;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/SessionFactoryFactoryTest.java

@@ -15,7 +15,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.*;
 
 public class SessionFactoryFactoryTest {

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/SessionFactoryHealthCheckTest.java

@@ -5,7 +5,7 @@
 import org.junit.Test;
 import org.mockito.InOrder;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Matchers.anyString;
 import static org.mockito.Mockito.*;
 

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/UnitOfWorkRequestDispatcherTest.java

@@ -10,8 +10,8 @@
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 import static org.mockito.Mockito.*;
 
 @SuppressWarnings("HibernateResourceOpenedButNotSafelyClosed")

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/UnitOfWorkResourceMethodDispatchAdapterTest.java

@@ -4,7 +4,7 @@
 import org.hibernate.SessionFactory;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 
 public class UnitOfWorkResourceMethodDispatchAdapterTest {

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/UnitOfWorkResourceMethodDispatchProviderTest.java

@@ -8,7 +8,7 @@
 
 import java.lang.reflect.Method;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 

dropwizard-hibernate/src/test/java/io/dropwizard/hibernate/UnitOfWorkTest.java

@@ -5,7 +5,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class UnitOfWorkTest {
     private static class Example {

dropwizard-jackson/src/test/java/io/dropwizard/jackson/AnnotationSensitivePropertyNamingStrategyTest.java

@@ -6,7 +6,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class AnnotationSensitivePropertyNamingStrategyTest {
     public static class RegularExample {

dropwizard-jackson/src/test/java/io/dropwizard/jackson/DiscoverableSubtypeResolverTest.java

@@ -4,7 +4,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class DiscoverableSubtypeResolverTest {
     private final ObjectMapper mapper = new ObjectMapper();

dropwizard-jackson/src/test/java/io/dropwizard/jackson/FuzzyEnumModuleTest.java

@@ -9,8 +9,8 @@
 import java.sql.ClientInfoStatus;
 import java.util.concurrent.TimeUnit;
 
-import static org.fest.assertions.api.Assertions.assertThat;
-import static org.fest.assertions.api.Assertions.failBecauseExceptionWasNotThrown;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown;
 
 public class FuzzyEnumModuleTest {
     private final ObjectMapper mapper = new ObjectMapper();

dropwizard-jackson/src/test/java/io/dropwizard/jackson/GuavaExtrasModuleTest.java

@@ -9,7 +9,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
-import static org.fest.assertions.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class GuavaExtrasModuleTest {
     private final ObjectMapper mapper = new ObjectMapper();