-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 2.7 #563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I'm wondering about what are your plans.
Should this land in a major version change? like 2.0
?
Also, I would like to hear @alimanfoo about the recommended change.
Some projects don't but generally they do bump the major version and I'd tend to agree, as it's a good way to signal for users. |
Some considerations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great addition and the needed next step for petl
.
But I wonder if also it would be possible before merging this PR:
- Make a compatibility break release, with a major version change to
2.0
. - Change all the planned breakage previously issued/reported for:
- Troublesome behavior change like convert() and fieldmap() swallow errors silently by default #365
- Awkward API changes
- Any modification that can impact end-users
- Executing extensive tests with File formats, Databases, and Remote file access
- Evolve the possibility of maintaining a branch for some time to:
- Tackling security vulnerabilities / CVE
- Giving some time for users that can't afford to upgrade right now
- Hear the improvements that people are aiming for after the merge.
- It's worth dropping python2.7 with no other planned improvement ?
- Check if anyone would like to commit some effort for Migrate to pytest #453
- Check if anyone would like to commit some time for [POC] added typing to materialize (breaks py27 tests) #559 or another feature that depends on dropping
py2.x
.
- Hear project founder @alimanfoo opinion.
Seems this has gotten out of sync, closing and it can be revisited afresh when the above issues are resolved. |
Yes, Sure. The evolution in this PR paves the road for migration. |
This PR has the objective of dropping support for EOL Python 2.7 to reduce maintenance burden, reduce use of CI resources, modernise the codebase, and allow new Python features to be freely used.
Fixes #478.
Changes
python_requires
and classifierscompat.py
----py36-plus
Checklist
Checklist for for pull requests including new code and/or changes to existing code...