Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Change instances of 'deleteAsync' to 'removeAsync' because of node-fs-extra update #5

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

motiazu
Copy link
Contributor

@motiazu motiazu commented Dec 13, 2015

Breaking change details:
jprichardson/node-fs-extra#171

node-fs-extra removed the deleteAsync alias and since this repo depends on their latest version, this repo's code failed to run.
Fixed issue and made sure it works in my company's build.

Also change comments about deleting to removing to keep a common terminology in the code.

…-extra update jprichardson/node-fs-extra#171

Change comments about deleting to removing to keep a common terminology in the code
peteward44 added a commit that referenced this pull request Dec 14, 2015
Change instances of 'deleteAsync' to 'removeAsync' because of node-fs-extra update
@peteward44 peteward44 merged commit c5263c2 into peteward44:master Dec 14, 2015
@peteward44
Copy link
Owner

Ah, thanks. I'll fix the versions of the dependencies properly as well and release a new version with this PR included. Ta

@peteward44
Copy link
Owner

It seems that fs-extra didn't follow proper semantic versioning guidelines and didn't increment their major version. So i'm going to leave the version ranges untouched

@motiazu
Copy link
Contributor Author

motiazu commented Dec 14, 2015

Why not remove it and keep a stable version? They released breaking changes without incrementing major versions, it can still happen again.

@peteward44
Copy link
Owner

You're right: It can still happen again. But by not observing semantic versioning I am going against npm package guidelines and my users are not automatically receiving 3rd party bug fixes. If you are using this in a production environment i'd recommend you shrinkwrap your project anyway in order to protect yourself from this; otherwise breaking changes is a risk you have to accept

@motiazu
Copy link
Contributor Author

motiazu commented Dec 17, 2015

Oh I didn't even know about shrinkwrap, this is great for my needs.
Thanks. When will I be able to change my dependency back to the version number instead of the repo url? Or can I already do that?

@peteward44
Copy link
Owner

I've published v1.2.2 which includes this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants