c-deps: bump RocksDB to pick up perf fix

Pick up cockroachdb#20 which fixes a performance regression that caused range tombstones to be added to some sstables unnecessarily which in turn could cause compactions that are larger than necessary. Revert the workaround to `TestRocksDBDeleteRangeCompaction` which was made due to the now fixed bug. Release note: None
petermattis · Oct 30, 2018 · d8707c3 · d8707c3
1 parent 18b44cc
commit d8707c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/c-deps/rocksdb b/c-deps/rocksdb
diff --git a/pkg/storage/engine/rocksdb_test.go b/pkg/storage/engine/rocksdb_test.go
@@ -1389,9 +1389,9 @@ func TestRocksDBDeleteRangeCompaction(t *testing.T) {
 	// sstable being deleted. Prior to the hack in dbClearRange, all of the
 	// sstables would be compacted resulting in 2 L6 sstables with different
 	// boundaries than the ones below.
-	_ = db.CompactRange(makeKey("c", 1), makeKey("c", numEntries), false)
+	_ = db.CompactRange(makeKey("c", 0), makeKey("c", numEntries), false)
 	verifySSTables(`
-5: "a000000000" - "c000000000"
+5: "a000000000" - "a000000000"
 6: "a000000000" - "a000009999"
 6: "b000000000" - "b000009999"
 `)
+20 −7		db/compaction_job.cc
+94 −0		db/db_range_del_test.cc
+2 −0		db/dbformat.cc
+1 −0		include/rocksdb/types.h