Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F implementations #3

Merged
merged 9 commits into from
Mar 27, 2017
Merged

F implementations #3

merged 9 commits into from
Mar 27, 2017

Conversation

peterklijn
Copy link
Owner

No description provided.

@peterklijn peterklijn requested a review from awulder March 26, 2017 17:14
Copy link
Collaborator

@awulder awulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

@@ -127,7 +166,7 @@ public static void it(String text) {
*/
public static void xit(String text, Invokable block) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decided to add the Invokable to this method and ignoring it here instead of ignoring it in the StaticRunnerSupport?

@peterklijn peterklijn merged commit 25c802b into master Mar 27, 2017
@peterklijn peterklijn deleted the f-implementations branch March 27, 2017 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants