Merge pull request #792 from petergoldstein/bugfix/766

Restore `with` method for compatibility with existing Rails code
petergoldstein · Oct 13, 2021 · a48f759 · a48f759
2 parents 9761ca4 + ff8b2d9
commit a48f759
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/dalli/client.rb b/lib/dalli/client.rb
@@ -324,6 +324,11 @@ def close
     end
     alias_method :reset, :close
 
+    # Stub method so a bare Dalli client can pretend to be a connection pool.
+    def with
+      yield self
+    end
+
     private
 
     def cas_core(key, always_set, ttl = nil, options = nil)

diff --git a/test/test_dalli.rb b/test/test_dalli.rb
@@ -742,5 +742,14 @@
       end
     end
 
+    it "supports the with method" do
+      memcached_persistent do |dc|
+        dc.with { |c| c.set("some_key", "some_value") }
+        assert_equal "some_value", dc.get("some_key")
+
+        dc.with { |c| c.delete("some_key") }
+        assert_nil dc.get("some_key")
+      end
+    end
   end
 end