Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of hashes shouldn't matter #93

Closed
peterbe opened this issue Oct 31, 2018 · 1 comment
Closed

Order of hashes shouldn't matter #93

peterbe opened this issue Oct 31, 2018 · 1 comment
Assignees
Labels

Comments

@peterbe
Copy link
Owner

peterbe commented Oct 31, 2018

Consider this example:

▶ python hashin.py -r ~/songsearch/requirements.txt --dry-run --update-all
--- Old
+++ New
...
 xmltodict==0.11.0 \
-    --hash=sha256:add07d92089ff611badec526912747cf87afd4f9447af6661aca074eeaf32615 \
-    --hash=sha256:8f8d7d40aa28d83f4109a7e8aa86e67a4df202d9538be40c0cb1d70da527b0df
+    --hash=sha256:8f8d7d40aa28d83f4109a7e8aa86e67a4df202d9538be40c0cb1d70da527b0df \
+    --hash=sha256:add07d92089ff611badec526912747cf87afd4f9447af6661aca074eeaf32615

Nothing has actually changed but for some reason, the order of the hashes is different this time. That would cause an unnecessary change.

@peterbe peterbe self-assigned this Oct 31, 2018
@peterbe
Copy link
Owner Author

peterbe commented Oct 31, 2018

Note, it is not safe to ignore the problem if the package (e.g. xmltodict) hasn't changed version number. The hashes could legitimately be different.

@peterbe peterbe added the bug label Oct 31, 2018
@peterbe peterbe changed the title Order of hashes are unpredictable Order of hashes shouldn't matter Oct 31, 2018
peterbe added a commit that referenced this issue Oct 31, 2018
peterbe pushed a commit that referenced this issue Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant