Update setup.py to make it compatible with Poetry #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry is a dependency and package manager for Python projects that is growing in usage and popularity. A recent update to the minor version (1.1 -> 1.2) makes one unable to install
mediawiki-parseras this repo'ssetup.pyis currently written, since it usesdistutilsin a way that is being deprecated. Somewhat related issue posted onpoetry's repo: python-poetry/poetry#6459Minor edits to
setup.pyresolves this issue. Usessetuptoolsinstead ofdistutilsto installmediawiki-parser. Tested install by publishing fork tomediawiki-parser-fixon PyPI and installing with Poetry. Am still able to install directly withpipas well. See here: https://pypi.org/project/mediawiki-parser-fix/