Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlite3 cleanup method #197

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

mo-krauti
Copy link
Contributor

This adds a public method that cleans up the sqlite3 connections.

Copy link
Owner

@peter-wangxu peter-wangxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test for that

also can you add a doc update around the shrink usage so that benifit others

@peter-wangxu
Copy link
Owner

@mo-pyy I suppose you were not aware of the nit above?

I am about to fix it after merging this.

Copy link
Owner

@peter-wangxu peter-wangxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peter-wangxu peter-wangxu merged commit 4645151 into peter-wangxu:master Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants