Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-99]Support db_file_name when creating queue #100

Merged
merged 1 commit into from
May 17, 2019
Merged

[GH-99]Support db_file_name when creating queue #100

merged 1 commit into from
May 17, 2019

Conversation

peter-wangxu
Copy link
Owner

As title

@peter-wangxu peter-wangxu force-pushed the enhancement/support_file_name branch from d2fbe2d to 125507e Compare May 16, 2019 06:51
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #100 into master will decrease coverage by 0.26%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage    95.4%   95.13%   -0.27%     
==========================================
  Files          16       16              
  Lines        1435     1438       +3     
  Branches      155      156       +1     
==========================================
- Hits         1369     1368       -1     
- Misses         46       48       +2     
- Partials       20       22       +2
Flag Coverage Δ
#python 95.13% <50%> (-0.27%) ⬇️
Impacted Files Coverage Δ
persistqueue/sqlbase.py 93.2% <50%> (-1.8%) ⬇️
persistqueue/queue.py 80.29% <0%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c843d9...125507e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #100 into master will decrease coverage by 0.26%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage    95.4%   95.13%   -0.27%     
==========================================
  Files          16       16              
  Lines        1435     1438       +3     
  Branches      155      156       +1     
==========================================
- Hits         1369     1368       -1     
- Misses         46       48       +2     
- Partials       20       22       +2
Flag Coverage Δ
#python 95.13% <50%> (-0.27%) ⬇️
Impacted Files Coverage Δ
persistqueue/sqlbase.py 93.2% <50%> (-1.8%) ⬇️
persistqueue/queue.py 80.29% <0%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c843d9...125507e. Read the comment docs.

@peter-wangxu peter-wangxu mentioned this pull request May 16, 2019
Closed
@peter-wangxu peter-wangxu changed the title Support db_file_name when creating queue [GH-99]Support db_file_name when creating queue May 16, 2019
@peter-wangxu peter-wangxu merged commit 1ea06d5 into master May 17, 2019
@peter-wangxu peter-wangxu deleted the enhancement/support_file_name branch May 17, 2019 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peter-wangxu