Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for proxy #122

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

xie-jinwei
Copy link
Contributor

@xie-jinwei xie-jinwei commented Sep 1, 2021

Octokit won't automatically read proxy setting from environment variables, causing this GitHub Action fail to run on a self-hosted GitHub Actions runner behind a proxy.

This PR fixes this. Now Octokit client will read proxy settings from environment variables on initialization (This PR is tested out on my own self-hosted GitHub Actions runner behind proxy)

Signed-off-by: xie-jinwei [email protected]

@peter-evans
Copy link
Owner

Hi @xie-jinwei

Thank you for contributing.

I actually have proxy support added to some of my other actions, but neglected to add it here. I would like the implementation to match other actions I maintain. Would you mind changing this PR to copy this implementation? Or I can do it if you prefer?

@xie-jinwei
Copy link
Contributor Author

Hi @xie-jinwei

Thank you for contributing.

I actually have proxy support added to some of my other actions, but neglected to add it here. I would like the implementation to match other actions I maintain. Would you mind changing this PR to copy this implementation? Or I can do it if you prefer?

Hi @peter-evans
Thanks for your response, I have updated the implementation to yours version, but still support both http_proxy and https_proxy.

@peter-evans
Copy link
Owner

Thanks for switching the implementation.

Please run npm run format to fix the formatting error.

@xie-jinwei
Copy link
Contributor Author

Thanks for switching the implementation.

Please run npm run format to fix the formatting error.

Thanks, Peter, I have updated this.

@peter-evans peter-evans merged commit 40877f7 into peter-evans:main Sep 2, 2021
@peter-evans
Copy link
Owner

Thank you again for contributing! Released as v2.3.0 / v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants