Add the node_id to the available output #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-evans
approved these changes
Apr 2, 2024
peter-evans
pushed a commit
that referenced
this pull request
Apr 2, 2024
|
Thank you for accepting and sorry about missing the documentation! |
|
No problem. Thank you! This was much more complete and tested than most contributions I receive. Appreciate it. |
github-merge-queue bot
referenced
this pull request
in 4m-mazi/gh-test
May 11, 2024
#730) This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [peter-evans/find-comment](https://togithub.com/peter-evans/find-comment) | action | minor | `v3.0.0` -> `v3.1.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/peter-evans/find-comment) | --- ### Release Notes <details> <summary>peter-evans/find-comment (peter-evans/find-comment)</summary> ### [`v3.1.0`](https://togithub.com/peter-evans/find-comment/releases/tag/v3.1.0) [Compare Source](https://togithub.com/peter-evans/find-comment/compare/v3.0.0...v3.1.0) ##### What's Changed - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.8 to 18.19.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/283](https://togithub.com/peter-evans/find-comment/pull/283) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.10 to 18.19.14 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/284](https://togithub.com/peter-evans/find-comment/pull/284) - build(deps): bump peter-evans/create-pull-request from 5 to 6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/285](https://togithub.com/peter-evans/find-comment/pull/285) - build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/286](https://togithub.com/peter-evans/find-comment/pull/286) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.14 to 18.19.15 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/287](https://togithub.com/peter-evans/find-comment/pull/287) - build(deps-dev): bump prettier from 3.2.4 to 3.2.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/288](https://togithub.com/peter-evans/find-comment/pull/288) - build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/289](https://togithub.com/peter-evans/find-comment/pull/289) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.15 to 18.19.17 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/290](https://togithub.com/peter-evans/find-comment/pull/290) - build(deps-dev): bump eslint from 8.56.0 to 8.57.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/291](https://togithub.com/peter-evans/find-comment/pull/291) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.17 to 18.19.18 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/292](https://togithub.com/peter-evans/find-comment/pull/292) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.18 to 18.19.21 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/293](https://togithub.com/peter-evans/find-comment/pull/293) - build(deps-dev): bump eslint-plugin-github from 4.10.1 to 4.10.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/294](https://togithub.com/peter-evans/find-comment/pull/294) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.21 to 18.19.22 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/295](https://togithub.com/peter-evans/find-comment/pull/295) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.22 to 18.19.24 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/297](https://togithub.com/peter-evans/find-comment/pull/297) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.24 to 18.19.26 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/298](https://togithub.com/peter-evans/find-comment/pull/298) - build(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 18.19.26 to 18.19.28 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/peter-evans/find-comment/pull/300](https://togithub.com/peter-evans/find-comment/pull/300) - feat: add the node_id to the available output by [@​amonshiz](https://togithub.com/amonshiz) in [https://github.com/peter-evans/find-comment/pull/299](https://togithub.com/peter-evans/find-comment/pull/299) ##### New Contributors - [@​amonshiz](https://togithub.com/amonshiz) made their first contribution in [https://github.com/peter-evans/find-comment/pull/299](https://togithub.com/peter-evans/find-comment/pull/299) **Full Changelog**: peter-evans/find-comment@v3.0.0...v3.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJzZW12ZXI6bm9uZSJdfQ==--> Co-authored-by: mazi-renovate[bot] <161091290+mazi-renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use this action to find comments for minimization but that seems to require using the GraphQL API. The GraphQL API requires the
node_idfor theminimizeCommentandunminimizeCommentmutations. Thankfully the REST API returns the GraphQLnode_idproperty and as long as this passes it back we can then use it in GraphQL mutations!I updated the action defintion, the declared shape of a
Comment, and all the tests (both intsand in the workflow).