Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private networking boolean option (Ex. tugboat create -p true mydrop... #75

Merged
merged 2 commits into from
Nov 22, 2013

Conversation

4n3w
Copy link
Collaborator

@4n3w 4n3w commented Nov 21, 2013

I've added private networking as an option to tugboat.

@petems
Copy link
Owner

petems commented Nov 21, 2013

Hi @4n3w, thanks for the PR!

Can you fix the tests (it looks like you just need to add the extra domain to the config_spec https://github.com/pearkes/tugboat/blob/master/spec/config_spec.rb#L40)

Could you also add a new test specific for this option on the CLI?

Thanks!

@4n3w
Copy link
Collaborator Author

4n3w commented Nov 22, 2013

Sure! The tests were failing before I made those changes but it was
probably my environment
On Nov 21, 2013 5:56 PM, "Peter Souter" [email protected] wrote:

Hi @4n3w https://github.com/4n3w, thanks for the PR!

Can you fix the tests (it looks like you just need to add the extra domain
to the config_spec
https://github.com/pearkes/tugboat/blob/master/spec/config_spec.rb#L40)

Could you also add a new test specific for this option on the CLI?

Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/75#issuecomment-29033128
.

Fix existing tests after adding private networking option
@4n3w
Copy link
Collaborator Author

4n3w commented Nov 22, 2013

Hey @petems I've fixed the tests; it likely makes sense to have another set of eyes on this!

@pearkes
Copy link
Collaborator

pearkes commented Nov 22, 2013

Thanks, merging!

pearkes added a commit that referenced this pull request Nov 22, 2013
Add private networking boolean option (Ex. tugboat create -p true mydrop...
@pearkes pearkes merged commit fc10264 into petems:master Nov 22, 2013
"ssh" => { "ssh_user" => ssh_user, "ssh_key_path" => ssh_key_path , "ssh_port" => ssh_port},
"defaults" => { "region" => region, "image" => image, "size" => size, "ssh_key" => ssh_key }
}
"authentication" => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, good shout on this change, makes it much easier to read 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants