Resolve the SSH key path later. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the user to use e.g. "~/.ssh/id_rsa" in their configuration file.
|
Sounds good to me. |
|
@Ferada Awesome, works for me too! 👍 |
petems
added a commit
that referenced
this pull request
Jan 31, 2015
Resolve the SSH key path later.
petems
added a commit
that referenced
this pull request
Jan 31, 2015
Accidentally introduced failure in #146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the user to use e.g. "~/.ssh/id_rsa"` in their configuration file, thereby solving issue #130 and #105.
@brandondrew does this work for you? I don't think generally allowing environment variables in the configuration file is necessary, as
"~"is enough here, so I just went with that.