[ftr] remove svlCommonPage.forceLogout(); for tests using SAML auth (e…

…lastic#187140)

## Summary

**tl; dr;** PR removes `svlCommonPage.forceLogout();` for test suites,
that use _SAML auth_ to Kibana with
`svlCommonPage.loginWithRole(<role>)` as this call is not needed.


More details:
`svlCommonPage.forceLogout();` was introduced together with
`svlCommonPage.login()` when FTR allowed only basic authentication with
`/login` route and operator user. Mixing basic auth with Cloud SAML auth
caused flakiness, probably some of you noticed inconsistent redirects to
Cloud UI in before/after hooks. Calling `/logout` route and handling
what happens next was important to reset Kibana state.

However with `svlCommonPage.loginWithRole(<role>)` it is no longer
needed, it works this way:
1. use Cloud SAML auth (mock IDP to replicate SAML locally) to generate
session based on provided project role
2. clear browser state: delete all cookies, clear session & local
storage, verify it succeeded
3. set cookie in browser, validate role/user is applied properly by
validating user profile in browser

Since we generate only 1 session per unique role within each FTR config
run, it is not possible to have 2 different sessions for the same user.
When your next test is calling `svlCommonPage.loginWithRole(<role>)`,
the cookie in browser and browser state overall will be reset
completely.

x-pack/test_serverless/functional/test_suites/common/platform_security/user_profiles/user_profiles.ts

@@ -20,10 +20,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       await pageObjects.svlCommonPage.loginWithRole(VIEWER_ROLE);
     });
 
-    after(async () => {
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
     describe('User details', async () => {
       it('should display correct user details', async () => {
         await pageObjects.common.navigateToApp('security_account');

x-pack/test_serverless/functional/test_suites/observability/advanced_settings.ts

@@ -22,10 +22,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       await pageObjects.common.navigateToApp('settings');
     });
 
-    after(async () => {
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
     it('renders the page', async () => {
       await retry.waitFor('title to be visible', async () => {
         return await testSubjects.exists('managementSettingsTitle');

x-pack/test_serverless/functional/test_suites/observability/cases/attachment_framework.ts

@@ -50,7 +50,6 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
         );
 
         await kibanaServer.savedObjects.cleanStandardList();
-        await svlCommonPage.forceLogout();
       });
 
       it('adds lens visualization to a new case', async () => {

x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts

@@ -42,7 +42,6 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
 
     after(async () => {
       await svlCases.api.deleteAllCaseItems();
-      await svlCommonPage.forceLogout();
     });
 
     describe('Closure options', function () {

x-pack/test_serverless/functional/test_suites/observability/cases/create_case_form.ts

@@ -35,7 +35,6 @@ export default ({ getService, getPageObject }: FtrProviderContext) => {
 
     after(async () => {
       await svlCases.api.deleteAllCaseItems();
-      await svlCommonPage.forceLogout();
     });
 
     it('creates a case', async () => {

x-pack/test_serverless/functional/test_suites/observability/cases/list_view.ts

@@ -29,7 +29,6 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
     after(async () => {
       await svlCases.api.deleteAllCaseItems();
       await cases.casesTable.waitForCasesToBeDeleted();
-      await svlCommonPage.forceLogout();
     });
 
     describe('empty state', () => {

x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts

@@ -41,7 +41,6 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
 
     after(async () => {
       await svlCases.api.deleteAllCaseItems();
-      await svlCommonPage.forceLogout();
     });
 
     describe('page', () => {

x-pack/test_serverless/functional/test_suites/observability/infra/header_menu.ts

@@ -21,7 +21,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
     after(async () => {
       await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
-      await pageObjects.svlCommonPage.forceLogout();
     });
 
     describe('Alerts dropdown', () => {

x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts

@@ -53,7 +53,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       await Promise.all([
         esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs'),
       ]);
-      await pageObjects.svlCommonPage.forceLogout();
     });
 
     describe('#Single Host Flyout', () => {

x-pack/test_serverless/functional/test_suites/observability/infra/infra.ts

@@ -34,10 +34,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       await pageObjects.svlCommonPage.loginWithRole('viewer');
     });
 
-    after(async () => {
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
     describe('Inventory page', function () {
       this.tags('includeFirefox');
       before(async () => {

x-pack/test_serverless/functional/test_suites/observability/infra/navigation.ts

@@ -30,10 +30,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       await svlObltNavigation.navigateToLandingPage();
     });
 
-    after(async () => {
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
     describe('when Hosts settings is on', () => {
       before(async () => {
         await setHostsSetting(true);

x-pack/test_serverless/functional/test_suites/observability/infra/node_details.ts

@@ -44,7 +44,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
       after(async () => {
         await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
-        await pageObjects.svlCommonPage.forceLogout();
       });
 
       describe('Osquery Tab', () => {

x-pack/test_serverless/functional/test_suites/observability/ml/anomaly_detection_jobs_list.ts

@@ -31,7 +31,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     });
 
     after(async () => {
-      await PageObjects.svlCommonPage.forceLogout();
       await ml.api.cleanMlIndices();
       await ml.testResources.cleanMLSavedObjects();
       await esArchiver.unload('x-pack/test/functional/es_archives/logstash_functional');

x-pack/test_serverless/functional/test_suites/observability/ml/search_bar_features.ts

@@ -49,10 +49,6 @@ export default function ({ getPageObjects }: FtrProviderContext) {
             await PageObjects.svlCommonPage.loginWithRole(role);
           });
 
-          after(async () => {
-            await PageObjects.svlCommonPage.forceLogout();
-          });
-
           describe('list features', () => {
             it('has the correct features enabled', async () => {
               await PageObjects.header.waitUntilLoadingHasFinished();

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/columns_selection.ts

@@ -41,7 +41,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     after(async () => {
       await synthtrace.clean();
-      await PageObjects.svlCommonPage.forceLogout();
     });
 
     describe('columns selection initialization and update', () => {

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/custom_control_columns.ts

@@ -42,7 +42,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     after(async () => {
       await synthtrace.clean();
-      await PageObjects.svlCommonPage.forceLogout();
     });
 
     describe('should render custom control columns properly', async () => {

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/data_source_selection_state.ts

@@ -37,10 +37,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.svlCommonPage.loginWithRole('viewer');
     });
 
-    after(async () => {
-      await PageObjects.svlCommonPage.forceLogout();
-    });
-
     describe('when no dataSourceSelection is given', () => {
       it('should initialize the "All logs" selection', async () => {
         await PageObjects.observabilityLogsExplorer.navigateTo();

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/data_source_selector.ts

@@ -44,10 +44,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.observabilityLogsExplorer.removeInstalledPackages();
     });
 
-    after(async () => {
-      await PageObjects.svlCommonPage.forceLogout();
-    });
-
     describe('as consistent behavior', () => {
       before(async () => {
         await PageObjects.observabilityLogsExplorer.navigateTo();

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/field_list.ts

@@ -41,7 +41,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     after(async () => {
       await synthtrace.clean();
-      await PageObjects.svlCommonPage.forceLogout();
     });
 
     describe('field list initialisation', () => {

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/filter_controls.ts

@@ -18,7 +18,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     });
 
     after('clean up archives', async () => {
-      await PageObjects.svlCommonPage.forceLogout();
       await kibanaServer.importExport.unload('test/functional/fixtures/kbn_archiver/discover');
     });
 

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/flyout.ts

@@ -61,7 +61,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     });
 
     after('clean up archives', async () => {
-      await PageObjects.svlCommonPage.forceLogout();
       if (cleanupDataStreamSetup) {
         cleanupDataStreamSetup();
       }

x-pack/test_serverless/functional/test_suites/observability/observability_logs_explorer/header_menu.ts

@@ -37,7 +37,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     });
 
     after(async () => {
-      await PageObjects.svlCommonPage.forceLogout();
       await kibanaServer.importExport.unload('test/functional/fixtures/kbn_archiver/discover');
       await esArchiver.unload(
         'x-pack/test/functional/es_archives/observability_logs_explorer/data_streams'

x-pack/test_serverless/functional/test_suites/observability/rules/rules_list.ts

@@ -103,7 +103,6 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
     });
 
     after(async () => {
-      await svlCommonPage.forceLogout();
       await svlUserManager.invalidateApiKeyForRole(roleAuthc);
     });
 

x-pack/test_serverless/functional/test_suites/observability/screenshot_creation/response_ops_docs/cases/list_view.ts

@@ -55,15 +55,11 @@ export default function ({ getPageObject, getPageObjects, getService }: FtrProvi
         roleAuthc
       );
       caseIdMonitoring = caseMonitoring.id;
+      await pageObjects.svlCommonPage.loginWithRole('admin');
     });
 
     after(async () => {
       await svlCases.api.deleteAllCaseItems();
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
-    beforeEach(async () => {
-      await pageObjects.svlCommonPage.loginWithRole('admin');
     });
 
     it('cases list screenshot', async () => {

x-pack/test_serverless/functional/test_suites/observability/screenshot_creation/response_ops_docs/connectors/server_log_connector.ts

@@ -18,10 +18,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await pageObjects.svlCommonPage.loginWithRole('admin');
     });
 
-    after(async () => {
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
     it('server log connector screenshots', async () => {
       await pageObjects.common.navigateToApp('connectors');
       await pageObjects.header.waitUntilLoadingHasFinished();

x-pack/test_serverless/functional/test_suites/observability/screenshot_creation/response_ops_docs/maintenance_windows/create_window.ts

@@ -19,10 +19,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       await pageObjects.svlCommonPage.loginWithRole('admin');
     });
 
-    after(async () => {
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
     it('create maintenance window screenshot', async () => {
       await pageObjects.common.navigateToApp('maintenanceWindows');
       await pageObjects.header.waitUntilLoadingHasFinished();

x-pack/test_serverless/functional/test_suites/security/ftr/advanced_settings.ts

@@ -22,10 +22,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       await pageObjects.common.navigateToApp('settings');
     });
 
-    after(async () => {
-      await pageObjects.svlCommonPage.forceLogout();
-    });
-
     it('renders the page', async () => {
       await retry.waitFor('title to be visible', async () => {
         return await testSubjects.exists('managementSettingsTitle');

x-pack/test_serverless/functional/test_suites/security/ftr/cloud_security_posture/compliance_dashboard.ts

@@ -58,7 +58,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
     after(async () => {
       await cspDashboard.index.remove();
-      await pageObjects.svlCommonPage.forceLogout();
     });
 
     describe('Kubernetes Dashboard', () => {