Skip to content

Commit

Permalink
fix: [Obs AI Ops > Log Rate Analysis][KEYBOARD]: Table rows have icon…
Browse files Browse the repository at this point in the history
… tooltips that do not receive keyboard focus (elastic#183734)

Closes: elastic/observability-dev#3400

## Description

The Obs LOg Rate Analysis table rows each have an icon that exposes a
tooltip when hovered, but that tooltip cannot take keyboard focus,
making it unavailable to keyboard users. Screenshot attached below.

### Steps to recreate
1. Open the [Obs Log Rate
Analysis](https://issue-serverless-bbumq-pr182542-d34c16.kb.eu-west-1.aws.qa.elastic.cloud/app/ml/aiops/log_rate_analysis_index_select)
view
2. Tab through the table, until focus is on an element after the table
in the source order
6. Verify the icons in the table row(s) never receive focus and the
tooltips never become visible

### What was changed?: 
1. `EuiToolTip` was replaced to more accessible `EuiIconTip`

### Screen:


https://github.com/elastic/kibana/assets/20072247/941a9b04-811f-4f01-bb48-00df96b1ced0
  • Loading branch information
alexwizp authored May 21, 2024
1 parent 163a04e commit 130bf7b
Showing 1 changed file with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ import type { IUiSettingsClient } from '@kbn/core/public';
import {
EuiFlexGroup,
EuiFlexItem,
EuiIcon,
EuiInMemoryTable,
EuiLink,
EuiSearchBarProps,
EuiTableFieldDataColumnType,
EuiText,
EuiToolTip,
EuiIconTip,
IconType,
PropertySort,
Query,
Expand Down Expand Up @@ -255,14 +255,14 @@ export class SavedObjectFinderUi extends React.Component<
).getIconForSavedObject(item.simple);

return (
<EuiToolTip position="top" content={currentSavedObjectMetaData.name}>
<EuiIcon
aria-label={currentSavedObjectMetaData.name}
type={iconType}
size="s"
data-test-subj="objectType"
/>
</EuiToolTip>
<EuiIconTip
position="top"
content={currentSavedObjectMetaData.name}
aria-label={currentSavedObjectMetaData.name}
type={iconType}
size="s"
data-test-subj="objectType"
/>
);
},
}
Expand Down

0 comments on commit 130bf7b

Please sign in to comment.