New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the startup warning for missing custom fields #85

Merged

peteeckel merged 1 commit into main from fix/custom-field-warning

Oct 20, 2023

Owner

peteeckel commented Oct 20, 2023 •

edited

Loading

There are multiple problems causing this:

The check for the feature enable status is done against the default settings, not the current settings of NetBox DNS. In the default settings, the feature is turned off, so the check code is never executed.
Logging is done against the logging instance netbox.config, which is not defined by default, so the log message wouldn't have appeared anywhere by default.

The new code writes the warning message to STDOUT, so it can be seen more easily.

fixes #84


          Fix the startup warning for missing custom fields

bc2cb37

peteeckel merged commit 0c9b9b9 into main

10 checks passed

peteeckel deleted the fix/custom-field-warning branch

October 20, 2023 11:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet