-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPAM Coupling #74
Merged
Merged
IPAM Coupling #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce an experimental IPAM-DNS coupling feature Two new custom fields are added on IP Address : - name - zone Through a middleware and signals, all IP Address creation and modification are intercepted. Using the new custom fields, the corresponding DNS record is created, modified or deleted accordingly. Permission on DNS records are enforced. The IP address "dns_name" field is also updated.
* The original names 'name' and 'zone' are very generic. Given that the CF names are global within NetBox, they were renamed so they don't clash with other field names so easily
* Simplified the query for the required CFs * Modified the log message to be a one-liner instead of four lines, which makes it hard to parse log messages automatically
* 'Related DNS Address Recordspanes' and 'Related DNS Pointer Records' panes in the ipam.IPAddress detail view now use records from 'ipam_coupling' * 'Related DNS Pointer Zones' pane in the ipam.IPPrefix view was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the work of @jean1 and a few small changes and enhancements.