Added warning for records masked by child zones

peteeckel · Oct 18, 2024 · 5424ff2 · 5424ff2
1 parent 369a31a
commit 5424ff2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/netbox_dns/templates/netbox_dns/record.html b/netbox_dns/templates/netbox_dns/record.html
@@ -43,6 +43,12 @@ <h5 class="card-header">{% trans "Record" %}</h5>
                     <th scope="row">{% trans "Name" %}</th>
                     <td style="word-break:break-all;">{{ object.name }}</td>
                 </tr>
+                {% if mask_warning %}
+                <tr class="text-warning">
+                    <th scope="row">{% trans "Warning" %}</th>
+                    <td>{{ mask_warning }}</td>
+                </tr>
+                {% endif %}
                 {% if unicode_name %}
                 <tr>
                     <th scope="row">{% trans "IDN" %}</th>

diff --git a/netbox_dns/views/record.py b/netbox_dns/views/record.py
@@ -139,6 +139,19 @@ def get_extra_context(self, request, instance):
         else:
             context["cname_table"] = self.get_cname_records(instance)
 
+        fqdn = dns_name.from_text(instance.fqdn)
+        name = dns_name.from_text(instance.name, origin=None)
+
+        if len(name) > 1 and not instance.is_glue:
+            if Zone.objects.filter(
+                name__in=get_parent_zone_names(
+                    instance.fqdn, min_labels=len(fqdn) - len(name)
+                )
+            ).exists():
+                context["mask_warning"] = _(
+                    "Record is masked by a child zone and may not be visible in DNS"
+                )
+
         return context