Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove common caught exception #1156

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Remove common caught exception #1156

merged 2 commits into from
Mar 9, 2024

Conversation

sliftist
Copy link
Contributor

@sliftist sliftist commented Mar 9, 2024

Float16Array construction always throws an exception, which is caught. This makes developing with Pause on caught exceptions annoying, because of the spurious caught errors.

The attached change removes a lot of these uncaught errors by immediately identifying any Array.isArray values as not being ArrayBuffers.

@sliftist sliftist requested a review from petamoriken as a code owner March 9, 2024 01:30
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (0d82f01) to head (d256c94).
Report is 6 commits behind head on master.

❗ Current head d256c94 differs from pull request most recent head d79920f. Consider uploading reports for the commit d79920f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
+ Coverage   87.06%   87.08%   +0.01%     
==========================================
  Files          12       12              
  Lines         773      774       +1     
  Branches      146      147       +1     
==========================================
+ Hits          673      674       +1     
  Misses         54       54              
  Partials       46       46              
Flag Coverage Δ
unittests 87.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/_util/is.mjs Outdated Show resolved Hide resolved
Co-authored-by: Kenta Moriuchi <[email protected]>
@sliftist
Copy link
Contributor Author

sliftist commented Mar 9, 2024

@petamoriken thanks for reviewing the pull request so quickly! I accepted the change in github, so it should be updated now.

@petamoriken petamoriken enabled auto-merge (squash) March 9, 2024 11:57
@petamoriken petamoriken merged commit 2fb3f59 into petamoriken:master Mar 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants